Closed Bug 1456603 Opened 7 years ago Closed 7 years ago

Tup backend: audit usage of check_unchanged=True

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Version:
3 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(1 file)

Bug 1456603 - Enable check_unchanged=True for more rules in the tup backend;
(deleted), text/x-review-board-request
chmanchester
: review+
Details
For ipdl and WebIDL, we use check_unchanged=True in the rule to skip downstream rules if the output is the same (ie: if a generated .cpp file is identical to the previous run, the corresponding .o file will be skipped). This should probably also be turned on for xpidl, and possibly all GeneratedFiles. We can investigate if it's also useful for compilation or other rules as well.
Assignee: nobody → mshal
Attachment #8974166 - Flags: review?(core-build-config-reviews) → review?(cmanchester)
Comment on attachment 8974166 [details] Bug 1456603 - Enable check_unchanged=True for more rules in the tup backend; https://reviewboard.mozilla.org/r/242448/#review248378
Attachment #8974166 - Flags: review?(cmanchester) → review+
Pushed by mshal@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c99ba2e8d166 Enable check_unchanged=True for more rules in the tup backend; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/c99ba2e8d166
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: