Brian Grinstead [:bgrins] Assignee
	Description • 6 years ago

Things like menus don't currently work, but we can get the code landed to make testing easier

	Nicolas Chevobbe [:nchevobbe]
	Comment 2 • 6 years ago
mozreview-review

Comment on attachment 8971326 [details]
Bug 1456663 - Add a preference to open webconsole.html directly in the Browser Console;

https://reviewboard.mozilla.org/r/240096/#review246056

so everything work when the pref is false, but when true, the jsconsole won't open. Is it expected ? If so, maybe it should be a bit clearer in the commit message :)

	Brian Grinstead [:bgrins] Assignee
	Comment 3 • 6 years ago

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)
> Comment on attachment 8971326 [details]
> Bug 1456663 - Add a preference to open webconsole.html directly in the
> Browser Console;
> 
> https://reviewboard.mozilla.org/r/240096/#review246056
> 
> so everything work when the pref is false, but when true, the jsconsole
> won't open. Is it expected ? If so, maybe it should be a bit clearer in the
> commit message :)

I think this should be fixed as of Bug 1454445 (there was an issue where there wasn't any default height/width)

	Nicolas Chevobbe [:nchevobbe]
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8971326 [details]
Bug 1456663 - Add a preference to open webconsole.html directly in the Browser Console;

https://reviewboard.mozilla.org/r/240096/#review246170

r+ since it doesn' break current behaviour

	Pulsebot
	Comment 5 • 6 years ago

Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9bd9695b7e0
Add a preference to open webconsole.html directly in the Browser Console;r=nchevobbe

	Andreea Pavel [:apavel]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a9bd9695b7e0