Closed Bug 1456756 Opened 7 years ago Closed 7 years ago

[TreeView] Left arrow on non expandable or collapsed node should select parent node.

Categories

(DevTools :: Shared Components, defect)

61 Branch
defect
Not set
minor

Tracking

(firefox61 verified, firefox62 verified)

VERIFIED FIXED
Firefox 62
Tracking Status
firefox61 --- verified
firefox62 --- verified

People

(Reporter: george.craciun, Assigned: yzen)

References

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0 Build ID: 20180424100107 [Affected versions]: Nightly 61.0a1 [Affected Platforms]: All [Prerequisites]: Accessibility tab is opened and enabled [Steps to reproduce]: 1.Click the "document" item from the "Role" panel. 2.Select the first line without a dropdown arrow 3.Press the "Left arrow" key and observe what happens next. [Expected result]: -The "document" parent row should be selected Please see Comment 1 from bug 1439630 [Actual result]: -Nothing happens, the "Left arrow" key is not used to navigate through lines. Note that in the Inspector Tab/Properties panel for example, pressing the "Left arrow" key on a child row without dropdown arrow, moves the selected row back to the parent and pressing again the "Left arrow" key closes the child row.
Blocks: 1151468
Please note that the issue is also occurring when using the "Right arrow" key.
Summary: Pressing the "Left arrow" key doesn't selects the parent item if a child item was previously selected → Pressing the "Left arrow"/"Right arrow" key doesn't navigate through the child rows of the "Role" panel
(In reply to Cristian Craciun from comment #1) > Please note that the issue is also occurring when using the "Right arrow" > key. Right arrow navigate to next node is not desired and is confusing to a11y users. We disable it by default in the VirtualizedTree component.
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Summary: Pressing the "Left arrow"/"Right arrow" key doesn't navigate through the child rows of the "Role" panel → Left arrow on non expandable or collapsed node should select parent node.
Component: Developer Tools: Accessibility Tools → Developer Tools: Shared Components
Summary: Left arrow on non expandable or collapsed node should select parent node. → [TreeView] Left arrow on non expandable or collapsed node should select parent node.
Attached patch 1456756 patch (obsolete) (deleted) — Splinter Review
Attachment #8981233 - Flags: review?(odvarko)
Comment on attachment 8981233 [details] [diff] [review] 1456756 patch Review of attachment 8981233 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch! R+, assuming try is green. Honza
Attachment #8981233 - Flags: review?(odvarko) → review+
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fc76999d8ee0 select parent row if available when ArrowLeft is pressed on collapsed or non-expandable row. r=Honza
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Attached patch 1456756 updated patch (deleted) — Splinter Review
Carry over
Attachment #8981233 - Attachment is obsolete: true
Attachment #8982209 - Flags: review+
Comment on attachment 8982209 [details] [diff] [review] 1456756 updated patch [Feature/Bug causing the regression]: Not a regression, supports a11y inspector deliverable for Fx61 [User impact if declined]: Users won't be able to use keyboard to jump to parent accessible object in accessibility tree when pressing ArrowLeft. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Same STR as in description. [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]: No [Why is the change risky/not risky?]: Just improves keyboard navigation, when pressing left arrow within TreeView [String changes made/needed]: None
Attachment #8982209 - Flags: approval-mozilla-beta?
Comment on attachment 8982209 [details] [diff] [review] 1456756 updated patch a11y inspector improvement. Approved for 61.0b11.
Attachment #8982209 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Hi Everyone , i managed to reproduce this issue using the 61.0a1 (2018-05-01) version of Nightly but i can no longer reproduce this issue on the later versions of it. I will mark this issue accordingly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: