Ben Kelly [:bkelly, not reviewing] Assignee
	Description • 6 years ago

In bug 1455695 I added a helper class to correctly disconnect MozPromise thenables when the global is disconnected.  We should use it in ServiceWorkerContainer.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 1 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d4ad65b9f6ef35ee8b91b6445c1f420083e4088

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 2 • 6 years ago

Comment on attachment 8971021 [details] [diff] [review]
Use DOMMozPromiseRequestHolder in ServiceWorkerContainer. r=baku

This patch makes us use the DOMMozPromiseRequestHolder in the ServiceWorkerContainer methods.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 3 • 6 years ago

Actually, we probably do need to wait for bug 1456466 so we can have the auto-suppressing CopyableErrorResult type.  Otherwise disconnecting a rejected MozPromise here will assert that the ErrorResult was not consumed.

	Pulsebot
	Comment 4 • 6 years ago

Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43385aef5932
Use DOMMozPromiseRequestHolder in ServiceWorkerContainer. r=baku

	Cosmin Sabou [:CosminS]
	Comment 5 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/43385aef5932