Ben Kelly [:bkelly, not reviewing] Assignee
	Description • 6 years ago

Currently we pass the global and jscontext down into ServiceWorker::Inner::PostMessage().  We need to keep these up in the binding layer and only pass portable types down into the Inner.  This probably means doing an IPC serialization of the structured cloneable transferable.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 1 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf523018335f702fef36bf60e7e47389c3ef7368

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 2 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6709635f7ed4ff81f5beb7f2248d327bf3f85062

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 3 • 6 years ago

I wrote bug 1458936 to make structured clone utilities easier here.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 4 • 6 years ago

Comment on attachment 8972920 [details] [diff] [review]
Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

Andrea, in preparation of remoting the ServiceWorker binding layer across IPC to the parent process this patch makes PostMessage() immediately convert to StructuredCloneData instead of passing the js pointers down into the guts of SWM.

Note, there is some ugly code in ServiceWorkerPrivate to convert from the StructuredCloneData to a StructuredCloneHolder.  This is necessary because SCD uses non-threadsafe ref-counting internally.  I filed bug 1458936 to make this better in the future.

	Andrea Marchesini [:baku]
	Comment 5 • 6 years ago

Comment on attachment 8972920 [details] [diff] [review]
Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

Review of attachment 8972920 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/serviceworkers/ServiceWorker.cpp
@@ +16,5 @@
>  #include "mozilla/dom/ClientState.h"
>  #include "mozilla/dom/Promise.h"
>  #include "mozilla/dom/ServiceWorkerGlobalScopeBinding.h"
>  #include "mozilla/dom/WorkerPrivate.h"
> +#include "mozilla/dom/ipc/StructuredCloneData.h"

Ok, I still don't understand how sort 'subdir' headers in alphabetic order...

	Pulsebot
	Comment 6 • 6 years ago

Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/509957c7a9f9
Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

	Cosmin Sabou [:CosminS]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/509957c7a9f9

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 8 • 6 years ago

Backing out for various issues:

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cd5006f1365420afb922ced1a1c07feaa27c951
https://hg.mozilla.org/releases/mozilla-beta/rev/10812be17bab3794c4f6d97b2128f6a0d8e156ea

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 9 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4df3b7c9f430af38e0561344781887b2c875d310

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 6 years ago

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/7cd5006f1365

	Pulsebot
	Comment 11 • 6 years ago

Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee57d9bde7cb
Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

	Eliza Balazs [:ebalazs_]
	Comment 12 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ee57d9bde7cb