Closed
Bug 1457180
Opened 7 years ago
Closed 7 years ago
gPrivacyPane.readKeepCookiesUntil() should support only ACCEPT_SESSION and ACCEPT_SESSION
Categories
(Firefox :: Settings UI, enhancement, P3)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Currently it supports ACCEPT_FOR_N_DAYS, but we don't have UI for this value.
I also filed bug 1457170 to get rid of ACCEPT_FOR_N_DAYS.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8971262 -
Flags: review?(gijskruitbosch+bugs)
|
||
Updated•7 years ago
|
|
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8971262 [details] [diff] [review]
session_pref.patch
Review of attachment 8971262 [details] [diff] [review]:
-----------------------------------------------------------------
You're not including a commit message, please ensure it doesn't do what the summary of the bug does and repeat ACCEPT_SESSION instead of (presumably) listing ACCEPT_NORMALLY.
Attachment #8971262 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Updated•7 years ago
|
Priority: -- → P3
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e44dc88af55c
gPrivacyPane.readKeepCookiesUntil() must support only nsICookieService.ACCEPT_SESSION and nsICookieService.ACCEPT_NORMALLY values, r=gijs
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•