Closed
Bug 1457227
Opened 7 years ago
Closed 6 years ago
Rename As router state.currentId to .lastId
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: k88hudson, Assigned: k88hudson)
References
(Blocks 1 open bug)
Details
(Whiteboard: [has-pr])
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
Right now, the .currentId in the general state for Activity Stream doesn't really make any sense, since different pages can have different messages. We should probably rename it to "lastId" or something so that it reflects what it actually is (i.e. the last message that was sent) and fix our blocking code to only block messages that match the blocked id.
|
Assignee | |
Updated•6 years ago
|
Iteration: --- → 62.1 - May 21
Priority: -- → P2
|
|
Assignee | |
Updated•6 years ago
|
Iteration: 62.1 - May 21 → 62.2 - Jun 4
|
||
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → khudson
Priority: P2 → P1
|
|
Assignee | |
Updated•6 years ago
|
Severity: normal → enhancement
|
|
Assignee | |
Updated•6 years ago
|
Whiteboard: [has-pr]
|
||
Comment 2•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/fe2cd10c2a26c914ec85274a6f2d9edab2fbbb0e Bug 1457227 - convert currentId to lastMessageId https://github.com/mozilla/activity-stream/commit/a1ee4b9fa07772796583698df417d2b6369e5dc0 Merge pull request #4161 from k88hudson/bug1457227 Bug 1457227 - convert currentId to lastMessageId
|
|
Assignee | |
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
||
Comment 3•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/238c2caac25d
status-firefox62:
--- → fixed
Target Milestone: --- → Firefox 62
|
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•