Closed
Bug 1457241
Opened 7 years ago
Closed 7 years ago
Update webrender to 4b65822a2f7e1fed246a492f9fe193ede2f37d74
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files)
+++ This bug was initially created as a clone of Bug #1456114 +++
I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.
When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".
[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Assignee | ||
Comment 1•7 years ago
|
||
WR @ 751236199b39bb8dac78522713133ca18c603fb3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd7c6d267128a62728e1a9c6afb2883b94bd7da4
Green
WR @ b763b540bc80400bbd4b7ee24129f4cd98998682
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91a8ffc2a53e5e4e70c7a2de3358bc5351cd0c02
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b6f3d29802caa54931079ac30ae7accc6ecc338
Green
Assignee | ||
Comment 2•7 years ago
|
||
WR @ 4b65822a2f7e1fed246a492f9fe193ede2f37d74
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0a428021be3e51d7988e1aed6a911f14eba88a0
Some reftest failures on linux, windows is still pending. Regression range:
* 4b65822a (HEAD -> master, origin/master, origin/auto, origin/HEAD) Auto merge of #2694 - glennw:screen-uv2, r=mrobinson
|\
| * d2892772 Allow texture cache entries to store non-rectangular UVs.
* 9921f2ee Auto merge of #2702 - glennw:slab-rects, r=mrobinson
|\
| * f653283d Support non-square slab allocator pages in texture cache.
* 4440d855 Auto merge of #2644 - nical:brush-repeat-enable, r=glennw
* b92439c8 Update reftest reference.
* 445e7a0c Repeat images in the brush shader when there is no spacing.
* ab991d89 Repeat radial gradients in the brush shader when there is no spacing.
* 0bb9bc43 Repeat linear gradients in the brush shader when there is no spacing.
Assignee | ||
Comment 3•7 years ago
|
||
Bisection push with WR @ 4440d85585e923a412a452ff7a39e419a272e011
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4d988eae089d461267498b7923523657d52ee68
Also has the reftest failures. So the regression is from servo/webrender#2644
Comment 4•7 years ago
|
||
These should be fixed by the reftest annotations I put a little while back in the patch of bug 1453935. Sorry I should have reminded you about them around the time of merging that PR. /layout/reftests/bugs/1291528.html Does have visible differences, however the regressing pull request fixes a lot more than it breaks so I decided that the test would be disabled for now.
Reenabling that reftest involves changing how gecko goes about repeating images and gradients with non-integer tile-sizes, which is not a huge deal but I'll get to it some time after I have made webrender support many rendering many repetitions which is a lot more common.
Assignee | ||
Comment 5•7 years ago
|
||
Thanks, I forgot about that bug. I'll land the patch as part of this bug along with the WR update, and leave that bug to track fixing the fails-if.
Depends on: 1453935
Assignee | ||
Comment 6•7 years ago
|
||
WR @ 4b65822a2f7e1fed246a492f9fe193ede2f37d74, with the patch that was on bug 1453935
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4fefa9113ade24f3c0c752705edda1912d30f2c
Some of the oranges got cleared up, but one remained on Linux and there are a bunch on Windows. I'll update the patch to fuzz those as well.
Assignee | ||
Comment 7•7 years ago
|
||
WR @ 4b65822a2f7e1fed246a492f9fe193ede2f37d74 with the windows stuff fuzzed too
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fcdda7a48e599117bf144a6163c31b67db03de6
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae3db939bc0798ff847dacb2452f5159e6b0926a
Looks like the 289480.html test in R8 is producing nondeterministic results; the fuzzy pixels varies from run to run. I'm going to mark it fails-if instead of fuzzy-if.
Assignee | ||
Comment 8•7 years ago
|
||
WR @ 4b65822a2f7e1fed246a492f9fe193ede2f37d74
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb0a0776c1a8859dabb16d6292207b3c9d4eb25d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4de2e9a44a4997e03622db6e401fa8ad9c6bb58
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e71296b3bc8883ee25e23d4bae116be85995d7a
Green with intermittents
Assignee | ||
Updated•7 years ago
|
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to 4b65822a2f7e1fed246a492f9fe193ede2f37d74
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8971987 [details]
Bug 1457241 - Add fuzziness to some of the gradient reftests.
https://reviewboard.mozilla.org/r/240730/#review246406
Attachment #8971987 -
Flags: review?(bugmail) → review+
Updated•7 years ago
|
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8971986 [details]
Bug 1457241 - Update webrender to commit 4b65822a2f7e1fed246a492f9fe193ede2f37d74.
https://reviewboard.mozilla.org/r/240728/#review246410
Attachment #8971986 -
Flags: review?(jmuizelaar) → review+
Comment 13•7 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b40c075c18a
Update webrender to commit 4b65822a2f7e1fed246a492f9fe193ede2f37d74. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/25c5ae00eb53
Add fuzziness to some of the gradient reftests. r=kats
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2b40c075c18a
https://hg.mozilla.org/mozilla-central/rev/25c5ae00eb53
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•