Closed
Bug 1457247
Opened 7 years ago
Closed 7 years ago
Add www.rememberthemilk.com into "dom.keyboardevent.keypress.hack.dispatch_non_printable_keys"
Categories
(Core :: DOM: Events, defect, P1)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | --- | fixed |
People
(Reporter: overholt, Assigned: masayuki)
References
Details
(Keywords: regression, site-compat)
Attachments
(1 file)
As in bug 1455059, Remember The Milk seems to have a bug to handle keypress events with Firefox. We need to include 'www.rememberthemilk.com' in the blacklist for Nightly testers.
Thanks!
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #0)
> As in bug 1455059, Remember The Milk seems to have a bug to handle keypress
> events with Firefox. We need to include 'www.rememberthemilk.com' in the
> blacklist for Nightly testers.
I don't find any Etherpad instance in Remember The Milk. Or, do you find something shortcut keys are broken on the todo app? As far as I've tested, I don't find it yet. If the former, let me know the URL of Etherpad instance. If the latter, please let me know the STR and file a Tech Evangelism bug.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(overholt)
Comment 2•7 years ago
|
||
I think overholt said up and down keys were broken.
Assignee | ||
Comment 3•7 years ago
|
||
Ah, I see, I reproduced it only in dropdown list.
Flags: needinfo?(overholt)
Assignee | ||
Comment 4•7 years ago
|
||
Filed bug 1457406 as Tech Evangelism.
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8971528 [details]
Bug 1457247 - Add "www.rememberthemilk.com" into the blacklist to allow to dispatch non-printable keypress events
https://reviewboard.mozilla.org/r/240276/#review246092
Attachment #8971528 -
Flags: review?(bugs) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/3f84124ca07b
Add "www.rememberthemilk.com" into the blacklist to allow to dispatch non-printable keypress events r=smaug
Comment 8•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•7 years ago
|
status-firefox59:
--- → unaffected
status-firefox60:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Reporter | ||
Comment 9•6 years ago
|
||
I don't have www.rememberthemilk.com in dom.keyboardevent.keypress.hack.dispatch_non_printable_keys because I thought it was working now, but keyboard events don't work for me in nightly on Windows 10 (at least on one machine). Is this expected?
Flags: needinfo?(masayuki)
Assignee | ||
Comment 10•6 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #9)
> I don't have www.rememberthemilk.com in
> dom.keyboardevent.keypress.hack.dispatch_non_printable_keys because I
> thought it was working now, but keyboard events don't work for me in nightly
> on Windows 10 (at least on one machine). Is this expected?
See bug 1457406 and bug 1464329. So, that means they have new regression now.
According to a developer of rememberthemilk.com, they use Google Closure. So, they are now use older version for avoiding some problems or new version of Google Closure now has regression.
Flags: needinfo?(masayuki)
Assignee | ||
Comment 11•6 years ago
|
||
I asked they still use newer Google Closure for conforming that whether this is Google Closures regression or not.
Assignee | ||
Comment 12•6 years ago
|
||
overholt:
According to an engineer of rememberthemilk, the regression is Google Closure's. (Perhaps, the fix was backed out tempoarily.) Now, their BETA build does not have the regression since they updated their Closure to v2252. And the fix is gonna come this Tuesday. So, we don't need to do anything for this issue anymore.
You need to log in
before you can comment on or make changes to this bug.
Description
•