Closed
Bug 1457390
Opened 7 years ago
Closed 6 years ago
Forward rust log to android_log on android
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
Rust log is print to stderr. But we want them to print to android_log on android.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Updated•7 years ago
|
Blocks: stage-wr-next
Priority: -- → P1
Comment hidden (obsolete) |
Assignee | ||
Comment 2•6 years ago
|
||
Checked logout of attachment 9002686 [details] [diff] [review] by enabling WebRender on android.
Example of logout was like the following
> 08-21 18:06:23.606 4759 4891 E webrender_bindings::bindings: WebRender - OpenGL version new OpenGL ES 3.2 V@251.0 (GIT@8aaecb6, Ib515ec08c2) (Date:10/19/17)
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #9002686 -
Flags: review?(jmuizelaar)
Comment 4•6 years ago
|
||
Comment on attachment 9002686 [details] [diff] [review]
patch - Forward rust log to android_log on android
Review of attachment 9002686 [details] [diff] [review]:
-----------------------------------------------------------------
Moving review to bholley
Attachment #9002686 -
Flags: review?(jmuizelaar) → review?(bobbyholley)
Comment 5•6 years ago
|
||
Comment on attachment 9002686 [details] [diff] [review]
patch - Forward rust log to android_log on android
Review of attachment 9002686 [details] [diff] [review]:
-----------------------------------------------------------------
It seems it would be cleaner to define a log_out function, with two variants (one android, one not(android)), and have have log() delegate to it. That way, we avoid the duplication of maybe_log_to_gfx_critical_note.
r=me with that change, assuming you're confident in the semantics of the _android_log_write stuff (I didn't double-check it).
Attachment #9002686 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 6•6 years ago
|
||
Address the comment.
Attachment #9002686 -
Attachment is obsolete: true
Attachment #9002996 -
Flags: review+
Assignee | ||
Comment 7•6 years ago
|
||
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/854353ad4d26
Forward rust log to android_log on android r=bholley
Comment 9•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 10•6 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•