Closed
Bug 1457517
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend v46
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 4 obsolete files)
(deleted),
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
early try run
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6abe84222f04c25208683001a9f2b54626f210f
the patch is quite large, but it is just packages shuffling. No actual source code changed.
Assignee | ||
Comment 2•7 years ago
|
||
another try run, but also includes the devtools-reps work
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d750502bfc0158e8120baad6c0fe90fdd92512a3
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8972561 -
Flags: review?(jdescottes)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8972561 -
Attachment is obsolete: true
Attachment #8972561 -
Flags: review?(jdescottes)
Attachment #8972733 -
Flags: review?(jdescottes)
Assignee | ||
Comment 5•7 years ago
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8972733 [details] [diff] [review]
rel-46-2.patch
Review of attachment 8972733 [details] [diff] [review]:
-----------------------------------------------------------------
devtools/client/debugger/new/test/mochitest/browser_dbg-stepping.js seems to have a high failure frequency on windows opt, we should probably look into this.
Somehow can't push to try right now, so talos comparisons will have to wait.
::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ -210,5 @@
> [browser_dbg-sourcemaps-reloading.js]
> [browser_dbg-sourcemaps2.js]
> [browser_dbg-sourcemaps3.js]
> [browser_dbg-sourcemaps-bogus.js]
> -skip-if = os == 'linux' && !asan # bug 1447118
missing sync from bug 1447118
Attachment #8972733 -
Flags: review?(jdescottes) → review+
Comment 7•7 years ago
|
||
Heads up also now missing sync from 1098374 -> https://github.com/devtools-html/debugger.html/pull/6234
Assignee | ||
Comment 8•7 years ago
|
||
thanks for the heads up. Here's a new try run and patch
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5208dfe74e11edf259116664e7c0c8042e914b21
Assignee | ||
Comment 9•7 years ago
|
||
Attachment #8972733 -
Attachment is obsolete: true
Attachment #8973764 -
Flags: review?(jdescottes)
Assignee | ||
Comment 10•7 years ago
|
||
I dont think we'll need this, but here is a try run sans reps
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f543c504e65ebbe360ab73454265a46b1aaefaf
I did this because i saw an error here - browser_webconsole_context_menu_store_as_global.js
but i think that is an old test... that isnt relevant
Assignee | ||
Comment 11•7 years ago
|
||
Attachment #8973764 -
Attachment is obsolete: true
Attachment #8973764 -
Flags: review?(jdescottes)
Attachment #8973772 -
Flags: review?(jdescottes)
Assignee | ||
Comment 12•7 years ago
|
||
this should be basically identical, but better safe than sorry
Assignee | ||
Comment 13•7 years ago
|
||
Attachment #8973772 -
Attachment is obsolete: true
Attachment #8973772 -
Flags: review?(jdescottes)
Attachment #8973845 -
Flags: review?(jdescottes)
Updated•7 years ago
|
Attachment #8973845 -
Flags: review?(jdescottes) → review+
Comment 14•7 years ago
|
||
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e31a502239b9
Update Debugger Frontend v46. r=jdescottes
Comment 15•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Comment 16•7 years ago
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•