Open Bug 1458068 Opened 7 years ago Updated 2 years ago

biquad-automation.html wpt test has data in test names

Categories

(Core :: Web Audio, enhancement, P2)

enhancement

Tracking

()

People

(Reporter: jgraham, Unassigned)

References

(Blocks 2 open bugs, )

Details

Attachments

(1 file, 1 obsolete file)

This is bad, because the names are supposed to be used as identifiers, but it's not clear that this data is constant.
Attached file disable.patch (obsolete) (deleted) —
Attached file disable.patch (deleted) —
Attachment #8972156 - Attachment is obsolete: true
I agree that looks bad. Is there a WPT issue for this already?
Rank: 15
Priority: -- → P2
Comment on attachment 8972159 [details] disable.patch LGTM
Attachment #8972159 - Flags: review+
For the record, the expected output is included in the message so you can tell what the output is. The attachment says the test fails, but it seems the last bit is left off, but it would have said something like "element-wise tolerance of {"absoluteThreshold":0.000027657,"relativeThreshold":0}" So the absolute difference between the actual and expected results exceeds 2.7657e-5. There would also be more text specifying what the actual max absolute (and relative) difference was.
Blocks: 1599954
Blocks: 1641461
Flags: sec-bounty?
Flags: needinfo?(james)
Flags: in-testsuite+
Flags: in-qa-testsuite+
Flags: behind-pref+
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: