Closed
Bug 1458921
Opened 6 years ago
Closed 6 years ago
regression: White vertical lines when scrolling text horizontally
Categories
(Core :: Graphics: WebRender, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | --- | disabled |
| firefox59 | --- | unaffected |
| firefox60 | --- | disabled |
| firefox61 | --- | disabled |
| firefox62 | --- | fixed |
People
(Reporter: jan, Assigned: lsalzman)
References
(Blocks 2 open bugs, )
Details
(Keywords: correctness, nightly-community, regression)
Attachments
(2 files, 4 obsolete files)
|
(deleted),
video/mp4
|
Details | |
|
(deleted),
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
Debian Testing, KDE, Xorg, Radeon RX480, 2560x1440 (Dell U2515H)
mozregression --good 2018-01-15 --bad 2018-04-01 --pref gfx.webrender.all:true general.autoScroll:true startup.homepage_welcome_url:'https://crash-stats.mozilla.com/report/index/b868a058-5274-4419-ac7c-a3a090180503#tab-metadata'
> 9:53.60 INFO: Last good revision: 73255f988eb133d3f515687cead96259d6fc0bb9
> 9:53.60 INFO: First bad revision: 94d10cf318b8f9c1b163a79afe978da9e47f01a8
> 9:53.60 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=73255f988eb133d3f515687cead96259d6fc0bb9&tochange=94d10cf318b8f9c1b163a79afe978da9e47f01a8
2018-02-09
> 94d10cf318b8 Lee Salzman — Bug 1396637 - disable WR subpixel positioning with FreeType. r=jrmuizel
|
||
Updated•6 years ago
|
Blocks: stage-wr-next
Priority: -- → P1
|
||
Updated•6 years ago
|
Assignee: nobody → lsalzman
See Also: → https://github.com/servo/webrender/pull/2738
|
Assignee | |
Comment 1•6 years ago
|
||
This just uses the new API introduced by https://github.com/servo/webrender/pull/2738
Or rather, the API for it has changed, and this patch is necessary to keep things working.
Attachment #8976288 -
Flags: review?(a.beingessner)
|
||
Updated•6 years ago
|
Attachment #8976288 -
Flags: review?(a.beingessner) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
Needed to add a bit of fuzz to make this work.
Attachment #8976288 -
Attachment is obsolete: true
Attachment #8980163 -
Flags: review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
WR PR 2738 got merged, so this patch will be necessary when we import it in a WR update.
Blocks: 1463416
|
|
||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f163bdabcdb0b687c5aac65ff36f46f34102a4a
Please update the patch to address the macOS reftest failures/passes.
Flags: needinfo?(lsalzman)
|
|
||
Comment 5•6 years ago
|
||
(Also please rebase it to m-c tip)
|
|
Assignee | |
Comment 6•6 years ago
|
||
Rebased and added more fuzz.
Attachment #8980163 -
Attachment is obsolete: true
Flags: needinfo?(lsalzman)
Attachment #8980646 -
Flags: review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
Fix some Windows fuzz ordering.
Attachment #8980646 -
Attachment is obsolete: true
Attachment #8980735 -
Flags: review+
|
|
Assignee | |
Comment 8•6 years ago
|
||
One last Mac fuzz fix.
Attachment #8980735 -
Attachment is obsolete: true
Attachment #8980762 -
Flags: review+
|
|
||
Comment 9•6 years ago
|
||
FYI in the first patch you had removed the fuzzy-if for windows on 1193519-sideways-lr-decoration-1-ref.html but at some point you put that back in. Still need that removed though. I'll make that change in the version of the patch that I'll put on bug 1463416.
|
|
Assignee | |
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
status-firefox62:
--- → fixed
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•