Closed
Bug 1459260
Opened 6 years ago
Closed 5 years ago
Allow APZ zooming without dom.meta-viewport.enabled
Categories
(Core :: Panning and Zooming, enhancement, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files)
Currently, APZ zooming requires dom.meta-viewport.enabled to be set. However, meta viewport tags only really make sense on mobile, and we want to support zooming on desktop as well, so we'd like to remove this requirement. In the absence of a meta viewport tag, the layout viewport would be sized to the device / browser window size.
|
Assignee | |
Comment 1•6 years ago
|
||
(And the initial zoom level would be 1, modulo any device scale or full-zoom.)
|
|
Assignee | |
Updated•6 years ago
|
Blocks: desktop-zoom-xp
|
|
Assignee | |
Updated•6 years ago
|
No longer blocks: desktop-zoom
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → botond
|
|
Assignee | |
Comment 2•5 years ago
|
||
However, we continue to only respect a <meta name="viewport"> tag if
dom.meta-viewport.enabled is set.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Many tests only had it enabled because it was required for zooming to work on
desktop. This patch revises tests to only use it if they actually use a non-
default meta viewport tag.
The motivation is to bring test coverage closer to the platform defaults (so
on desktop, tests will run with dom.meta-viewport.enabled=false, and on Android
with dom.meta-viewport.enabled=true, matching the production scenarios).
Depends on D30988
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db30d35f7130 Create a MobileViewportManager whenever apz.allow_zooming is set. r=kats https://hg.mozilla.org/integration/autoland/rev/ab450513a156 Don't use dom.meta-viewport.enabled in tests that don't need it. r=kats
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/db30d35f7130
https://hg.mozilla.org/mozilla-central/rev/ab450513a156
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•