Closed
Bug 1459289
Opened 7 years ago
Closed 7 years ago
Compact Highlight Cards
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox62 | --- | verified |
People
(Reporter: rrosario, Assigned: rrosario)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Let's implement the new smaller highlight cards!
Trello: https://trello.com/c/KtffMVhY/185-compact-highlight-cards
Mockups: https://mozilla.invisionapp.com/share/5THO85V3M7P#/293931290_Option_1
Updated•7 years ago
|
Assignee: nobody → rrosario
Iteration: --- → 62.1 - May 21
Priority: -- → P1
Updated•7 years ago
|
Severity: normal → enhancement
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
In addition to the style changes, while working on this with UX (Bryan Bell), we decided to make the following changes:
* changed highlights to two rows instead of 3
* fill all the possible/max rows with placeholders instead of just the current row
* on narrow screens, we hide the last two highlights (like we do for top sites)
* no longer showing file type for downloads
* if a link has no image (all downloads), we now show a grey box where the image goes instead of pushing the text to the top
Updated•7 years ago
|
Iteration: 62.1 - May 21 → 62.2 - Jun 4
Updated•7 years ago
|
Comment 3•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/e9b6cf72abd6ac59223f3be5ce86887f9fbf1752
Fix Bug 1459289 - compact cards for highlights
https://github.com/mozilla/activity-stream/commit/f18fffe9fef4dd06684656ce33f05bfce78fe148
Merge pull request #4159 from rlr/Bug1459289/compact-highlights
Fix Bug 1459289 - compact cards for highlights
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 4•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/fdda2139280fd798002196bf8e71f5a7dc2001af
chore(highlights): Update mochitest to check for 2 rows of placeholders (#4167)
Followup Bug 1459289 - Compact Highlight Cards
Comment 5•7 years ago
|
||
status-firefox62:
--- → fixed
Target Milestone: --- → Firefox 62
Comment 6•6 years ago
|
||
The issue is no longer reproducible on the latest Nightly build on Windows 10 x64, Mac 10.13.3 and Arch Linux x64. All the additional changes mentioned in comment 2 have also been verified.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•