Closed
Bug 1459302
Opened 7 years ago
Closed 5 years ago
Generate buildhub.json for l10n repacks
Categories
(Firefox Build System :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: ted, Unassigned)
References
Details
bug 1442306 added code to generate a buildhub.json file during packaging. Unfortunately it doesn't work for l10n repacks, which is something we do want. I'm splitting this off to a separate bug so I can land the patches on that bug.
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → ted
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Comment 3•6 years ago
|
||
Pardon intrusion, but can I ask what the status of this is.
In https://bugzilla.mozilla.org/show_bug.cgi?id=1443873 we're waiting for Mihai to wrap up the work of fixing the download.url and making sure the actual buildhub.json file gets uploaded.
Is there anything I can do to help on this bug?
Updated•6 years ago
|
Comment 4•6 years ago
|
||
I noticed Mihai's update, is buildhub.json now being generated for l10n repacks?
Comment 5•6 years ago
|
||
Any progress on this on Ted?
Reporter | ||
Comment 6•6 years ago
|
||
I went around and around on this a few times and couldn't figure out a reasonable place to put this (seemingly simple) logic in the rat's nest that is our l10n repack setup. I know this is blocking useful work on the buildhub side so I talked to Callek today about a potential implementation and he seemed OK with it.
We currently have `EN_US_BINARY_URL` defined to point to the en-US package in l10n repack tasks:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/taskcluster/ci/l10n/kind.yml#108
We could similarly define an `EN_US_BUILDHUB_URL` there to point to the en-US buildhub.json.
Then we would fetch that buildhub.json file when we fetch the en-US package:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/scripts/desktop_l10n.py#353
I'd just do it directly in the mozharness Python instead of trying to wire it into the build system. Then, somewhere in the `make_upload` function in the mozharness script we'd read the en-US buildhub.json and update the target.locale and download.* keys that differ from en-US:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/scripts/desktop_l10n.py#444-502
The only finicky bit there would be determining the installer/package filename, since mozharness and the build system are kind of at arm's length here. I think that much is manageable though.
Updated•6 years ago
|
Version: Version 3 → 3 Branch
Reporter | ||
Updated•6 years ago
|
Assignee: ted → nobody
Comment 7•5 years ago
|
||
Ben, since we're starting to own buildhub stuff, do you know anything about this and if its still wanted/needed?
Flags: needinfo?(bhearsum)
Comment 8•5 years ago
|
||
I did some digging and most (all?) of the stakeholders have weighed in on https://github.com/mozilla-releng/buildhub2/issues/477 and are OK with not having l10n data. Let's close this as WONTFIX, and we'll re-open if needed.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(bhearsum)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•