Closed
Bug 145947
Opened 23 years ago
Closed 13 years ago
Occurences of uninitialized variables being used before being set (in modules/plugin)
Categories
(Core Graveyard :: Plug-ins, defect, P3)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
Future
People
(Reporter: mozilla-bugs, Assigned: peterl-bugs)
References
Details
(Whiteboard: [PL2:NA][patch needs revisiting])
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
srgchrpv
:
review+
|
Details | Diff | Splinter Review |
This bug is just for the "xxx might be used uninitialized" warnings in various
source files in modules/plugin. Currently
(http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1021964760.29906.gz&fulltext=1
- Tue, 21 May 2002 03:06 -0400) TBox shows the following warnings:
modules/plugin/base/src/nsPluginHostImpl.cpp:5878
`nsresult rv' might be used uninitialized in this function
modules/plugin/samples/default/unix/nullplugin.c:186
`ele_prev' might be used uninitialized in this function
|
Reporter | |
Comment 1•23 years ago
|
||
Bug 59652 is the meta-bug tracking the fight against these (potentially very
nasty) warnings.
Blocks: 59652
|
||
Comment 2•23 years ago
|
||
Does this patch help the warning in nsPluginHostImpl.cpp?
|
|
Reporter | |
Comment 3•23 years ago
|
||
It may be better to propagate up the do_GetService error instead of using the
generic NS_ERROR_FAILURE.
This patch also fixes another similar warning (that for some reason only shows
on my machine, but not on TBox).
|
||
Comment 4•23 years ago
|
||
handing over to serge
Assignee: beppe → serge
Priority: -- → P3
Target Milestone: --- → mozilla1.2alpha
|
||
Comment 5•23 years ago
|
||
Comment on attachment 84459 [details] [diff] [review]
Alternative solution
I assume this shows only on yours box.
>- char *p; // tmp ptr into new output buf
>+ char *p = nsnull; // tmp ptr into new output buf
actually this pointer is not in use before first assignment, so smart enough
compiler should not warn on this.
r=serge
Attachment #84459 -
Flags: review+
|
|
||
Updated•22 years ago
|
Whiteboard: [PL2:NA][NEED SR=]
Target Milestone: mozilla1.2alpha → mozilla1.0.2
|
|
||
Updated•22 years ago
|
Target Milestone: mozilla1.0.2 → mozilla1.3alpha
|
|
||
Comment 6•22 years ago
|
||
future
Assignee: serge → peterl
Whiteboard: [PL2:NA][NEED SR=] → [PL2:NA][patch needs revisiting]
Target Milestone: mozilla1.3alpha → Future
|
||
Updated•22 years ago
|
Summary: Occurances of uninitialized variables being used before being set (in modules/plugin) → Occurences of uninitialized variables being used before being set (in modules/plugin)
|
||
Updated•15 years ago
|
QA Contact: shrir → plugins
|
||
Comment 7•13 years ago
|
||
modules/plugin/base/src/nsPluginHostImpl.cpp no longer exists.
|
||
Comment 8•13 years ago
|
||
modules/plugin directory does not exist anymore and hence closing this bug.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•