Closed Bug 1459590 Opened 7 years ago Closed 6 years ago

(Android) Check that things handled by SelectHelper.jsm (<select> elements etc.) work with ShadowDOM

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
enhancement
Priority:
Not set
Severity:
major

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: JanH, Assigned: edgar)

References

Details

Attachments

(4 files)

Test <select> element in shadow dom
(deleted), text/html
Details
Bug 1459590 - Ensure Fennec select and input element work with ShadowDom;
(deleted), text/x-phabricator-request
jchen
: review+
Details
shadow_datetime.html
(deleted), text/html
Details
Bug 1459590 - Ensure GeckoView select and input element work with ShadowDom;
(deleted), text/x-phabricator-request
jchen
: review+
Details
Summary: Check that things handled by SelectHelper.jsm (<select> elements etc.) work with ShadowDOM → (Android) Check that things handled by SelectHelper.jsm (<select> elements etc.) work with ShadowDOM
This is one of the few blockers shipping Shadow DOM, so if anyone could take a look at this, great.
Assignee: nobody → echen
I assume event.composedTarget would be useful here.
Attached file Test <select> element in shadow dom (deleted) —
Test case for <select> element in shadow dom. Fennec doesn't show the select menu while clicking the <select> element inside the shadow dom.
(In reply to Olli Pettay [:smaug] (vacation Jul 15->) from comment #2) > I assume event.composedTarget would be useful here. Yeah, using event.composedTarget fixes the issue in Fennec.
Attached file shadow_datetime.html (deleted) —
I found DateTime input type has a similar issue with ShadowDom. Here is the test script.
Attachment #8992289 - Attachment description: Bug 1459590 - Ensure Fennec select element work with ShadowDom; → Bug 1459590 - Ensure Fennec select and input element work with ShadowDom;
Attachment #8992289 - Flags: review?(snorp)
Attachment #8992294 - Flags: review?(snorp)
Attachment #8992289 - Flags: review?(snorp) → review?(nchen)
Attachment #8992294 - Flags: review?(snorp) → review?(nchen)
(apparently snorp is on pto)
Comment on attachment 8992289 [details] Bug 1459590 - Ensure Fennec select and input element work with ShadowDom; Jim Chen [:jchen] [:darchons] has approved the revision. https://phabricator.services.mozilla.com/D2151
Attachment #8992289 - Flags: review+
Comment on attachment 8992294 [details] Bug 1459590 - Ensure GeckoView select and input element work with ShadowDom; Jim Chen [:jchen] [:darchons] has approved the revision. https://phabricator.services.mozilla.com/D2153
Attachment #8992294 - Flags: review+
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bbf774e9e48 Ensure Fennec select and input element work with ShadowDom; r=jchen
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3de5d538b2d4 Ensure GeckoView select and input element work with ShadowDom; r=jchen
https://hg.mozilla.org/mozilla-central/rev/3bbf774e9e48
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: