Closed Bug 1459617 Opened 7 years ago Closed 7 years ago

WebRTC ASan build fails with recent trunk clang (fixed in WebRTC upstream)

Categories

(Core :: WebRTC, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(1 file)

We'll need this fix: https://webrtc.googlesource.com/src/+/bda78c9464f4d0e6ff26b0035624a967269c3b0a Dan, do you know if this will be included in the next webrtc merge, and/or can I cherry pick this patch in the meantime? Thanks!
Flags: needinfo?(dminor)
Blocks: winasan
I'm afraid you'll need to cherry pick. The next webrtc merge will be of branch 64, which is from mid-January.
Flags: needinfo?(dminor)
Rank: 19
Priority: -- → P2
Can I just land this as-is? Or do I need to leave a .patch file in the tree somewhere? I don't see any existing ones under media/webrtc.
Attachment #8974144 - Flags: review?(dminor)
Comment on attachment 8974144 [details] [diff] [review] Cherry-pick upstream webrtc asan build fix Review of attachment 8974144 [details] [diff] [review]: ----------------------------------------------------------------- lgtm, thanks! Don't worry about a patch file, the update after branch 64 will include this anyway.
Attachment #8974144 - Flags: review?(dminor) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d5b4c508bebd Merge upstream webrtc fix for build bustage with clang trunk. r=dminor
Assignee: nobody → dmajor
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: