Closed Bug 1459682 Opened 7 years ago Closed 3 years ago

layout/base/tests/test_after_paint_pref.html fails in Windows ASan builds

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: away, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Probably a duplicate of bug 1458365 but opening a new one just in case.
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/139dd5338407 Skip test_after_paint_pref.html in Windows ASan builds. DONTBUILD
Priority: -- → P3
Blocks: 1347793
The leave-open keyword is there and there is no activity for 6 months. :svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
Flags: needinfo?(svoisen)
Keywords: leave-open

I just landed a patch in bug 1720485 to fix a race condition in this test. (It recently became racy on non-Windows platforms, not just Windows.) It's likely that will have fixed the failure here, too.

If that bug's patch sticks, we can remove the annotation (i.e. back out comment 2) and close this out. Setting ni=myself to remember to do that.

Flags: needinfo?(dholbert)

This test was disabled for some sort of failure there, several years ago.
(The bug doesn't have details on the failure.)

It's likely the failure was a version of the same race condition that turned up
and was fixed in bug 1720485, so let's see if we can reenable it now.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Flags: needinfo?(dholbert)
Attachment #9235732 - Attachment description: Bug 1459682: Reenable test_after_paint_pref.html on Windows ASAN builds. r?mattwoodrow → Bug 1459682: Reenable test_after_paint_pref.html on Windows ASAN builds. (no review; just a metadata tweak to reenable a test that's now been fixed)
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b72709fc51ef Reenable test_after_paint_pref.html on Windows ASAN builds. (no review; just a metadata tweak to reenable a test that's now been fixed)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: