Closed Bug 1459948 Opened 6 years ago Closed 1 year ago

Don't include super long data URIs in Highlights

Categories

(Firefox :: New Tab Page, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox61 --- wontfix
firefox62 --- fix-optional

People

(Reporter: ntim, Unassigned)

References

Details

Attachments

(2 files)

STR:
- Have highlights disabled
- Visit a super long data URI
- Enable Highlights
- Open the new tab page

AR:
- Firefox freezes
- The super long data URI appears on the new tab page

ER:
- Highlights should be smart and ignore the super long URL for performance concerns
Attached file long-data-uri.txt (deleted) —
Here's the data URI (was too large to put in a comment).
Whiteboard: [fxperf]
Setting this as a P3 and fix-optional for this release unless there are strong objections.  Thoughts :ntim
Priority: -- → P3
Another way to trigger this is to execute the following in the developer toolbar:

>> screenshot --fullpage


That pretty much makes the newtab page unusable for me until I clear my downloads.
Highlights after a screenshot from Developer Toolbar.
Not a common case, but when it happens, it apparently makes the new tab unusable. To fix it or could just not show data: URIs at all, or establish a length limit to crop
Whiteboard: [fxperf] → [fxperf:p2]
The UI issue in Comment 4 was fixed by Bug 1464349.
Whiteboard: [fxperf:p2] → [fxperf:p3]
Component: Activity Streams: Newtab → New Tab Page
Severity: normal → S3

I don't think this is relevant with the current about:newtab anymore. Please feel free to reopen if this still applies in some way that I have overlooked.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
Whiteboard: [fxperf:p3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: