Closed
Bug 1460198
Opened 7 years ago
Closed 7 years ago
Fix setRef for about URIs
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
This xpcshell test fails:
let uri1 = gIoService.newURI("about:blank#");
let uri2 = gIoService.newURI("about:blank");
let uri3 = uri1.mutate().setRef("").finalize();
do_check_uri_eq(uri3, uri2);
This is due to about URIs being nestedURIs, and the innerURI for uri3 is still about:blank#
|
Assignee | |
Comment 1•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8974908 [details]
Bug 1460198 - When calling SetRef/SetQuery/SetPathQueryRef you should do the same for the inner URI
https://reviewboard.mozilla.org/r/243236/#review249246
::: netwerk/test/unit/test_URIs.js:522
(Diff revision 1)
> Assert.equal(testURI.ref, "");
> }
> }
> }
>
> +// Check that changing nested/about URIs works correctly.
Would be good to have tests for setQuery() and setRef() with nonempty strings too.
Attachment #8974908 -
Flags: review?(bzbarsky) → review+
| Comment hidden (mozreview-request) |
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/585f8951090b
When calling SetRef/SetQuery/SetPathQueryRef you should do the same for the inner URI r=bz
|
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•