Open Bug 1460340 Opened 7 years ago Updated 2 years ago

Windows ASan packages are missing firefox.pdb

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement

Tracking

(Not tracked)

People

(Reporter: away, Unassigned)

Details

https://queue.taskcluster.net/v1/task/cYU1RvlXTTaEfWTjgqrJkw/runs/0/artifacts/public/build/target.zip has symbols for our .dll files, but not our .exe files. This will probably become moot if we land bug 1460329.
(In reply to David Major [:dmajor] from comment #0) > This will probably become moot if we land bug 1460329. Maybe, but non-ASan builds don't put pdb files in the application package, so that might not produce the results you want. If chmanchester fixes bug 1459764, maybe we could simplify all of the ASan symbol copying stuff by simply changing `LINK_PDBFILE` for ASan builds: https://dxr.mozilla.org/mozilla-central/rev/0cd106a2eb78aa04fd481785257e6f4f9b94707b/config/rules.mk#150 to be `$(basename $@).pdb`, so that pdb files would get generated right next to their binaries in dist/bin. `$(@F)` is the GNU make variable for "just the filename of the current target", so currently we run: link.exe -OUT:../../dist/bin/firefox.exe -PDB:firefox.pdb and with that change we'd instead run: -OUT:../../dist/bin/firefox.exe -PDB:../../dist/bin/firefox.pdb Actually I guess we could make this change now and it ought to fix this bug, and maybe wouldn't harm anything else?
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1) > (In reply to David Major [:dmajor] from comment #0) > > This will probably become moot if we land bug 1460329. > > Maybe, but non-ASan builds don't put pdb files in the application package, > so that might not produce the results you want. But if bug 1460329 lands, we won't care about symbols being in the application package, right? If firefox.pdb winds up in crashreporter.symbols-full.zip, I'd be perfectly fine with that.
Version: Version 3 → 3 Branch
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.