Closed
Bug 1460371
Opened 6 years ago
Closed 6 years ago
Update Debugger Frontend v51
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5b548fcca407f4d9d3f935d1813be53dd737840
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8974471 -
Attachment is obsolete: true
Attachment #8974471 -
Flags: review?(jdescottes)
Attachment #8974474 -
Flags: review?(jdescottes)
Comment 4•6 years ago
|
||
Waiting for a greener try to review. An overall comment is that if we could have file moves rather than delete/add, this would make the diff much easier to read. Not sure what you need to do from git-cinnabar to achieve that though.
Assignee | ||
Comment 5•6 years ago
|
||
Attachment #8974474 -
Attachment is obsolete: true
Attachment #8974474 -
Flags: review?(jdescottes)
Attachment #8974694 -
Flags: review?(jdescottes)
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cedc6e9f42ba67c1944dec71614b04fd77f4be49
Comment 7•6 years ago
|
||
Comment on attachment 8974694 [details] [diff] [review] rel-51-3.patch Review of attachment 8974694 [details] [diff] [review]: ----------------------------------------------------------------- Works for me. As discussed: need to update the path in browser_parsable_css. I would honestly feel better if we didn't land the src/test folder to avoid polluting the repo. At the very least remove the 'test' entry from the DIRS in src/moz.build . Up to you. Follow ups for next release: - stop copying tests to src/test - check what should be done about vendors.css
Attachment #8974694 -
Flags: review?(jdescottes) → review+
Assignee | ||
Comment 8•6 years ago
|
||
Attachment #8974694 -
Attachment is obsolete: true
Attachment #8974733 -
Flags: review+
Assignee | ||
Comment 9•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4449f93930817877a0dc975e8370378c7cc7737
Comment 10•6 years ago
|
||
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b54faaaa591c Update Debugger Frontend v51 r=jdescottes
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b54faaaa591c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•6 years ago
|
Blocks: node-debugger
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•