Closed Bug 1460371 Opened 6 years ago Closed 6 years ago

Update Debugger Frontend v51

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch rel-51-1.patch (obsolete) (deleted) — Splinter Review
Attachment #8974471 - Flags: review?(jdescottes)
Assignee: nobody → jlaster
Priority: -- → P3
Attached patch rel-51-2.patch (obsolete) (deleted) — Splinter Review
Attachment #8974471 - Attachment is obsolete: true
Attachment #8974471 - Flags: review?(jdescottes)
Attachment #8974474 - Flags: review?(jdescottes)
Waiting for a greener try to review. 

An overall comment is that if we could have file moves rather than delete/add, this would make the diff much easier to read. Not sure what you need to do from git-cinnabar to achieve that though.
Attached patch rel-51-3.patch (obsolete) (deleted) — Splinter Review
Attachment #8974474 - Attachment is obsolete: true
Attachment #8974474 - Flags: review?(jdescottes)
Attachment #8974694 - Flags: review?(jdescottes)
Comment on attachment 8974694 [details] [diff] [review]
rel-51-3.patch

Review of attachment 8974694 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.

As discussed: need to update the path in browser_parsable_css.
I would honestly feel better if we didn't land the src/test folder to avoid polluting the repo.
At the very least remove the 'test' entry from the DIRS in src/moz.build . Up to you.

Follow ups for next release:
- stop copying tests to src/test
- check what should be done about vendors.css
Attachment #8974694 - Flags: review?(jdescottes) → review+
Attached patch rel-51-4.patch (deleted) — Splinter Review
Attachment #8974694 - Attachment is obsolete: true
Attachment #8974733 - Flags: review+
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b54faaaa591c
Update Debugger Frontend v51 r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/b54faaaa591c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: