Closed Bug 1460624 Opened 6 years ago Closed 6 years ago

FLBDisplayItemIterator uses a std::list for a FIFO buffer

Categories

(Core :: Web Painting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Details

Attachments

(1 file)

As far as I know the best data structure the STL has for this is a deque, switching to a deque causes a noticeable performance improvement on testcases which rely heavily on this code.
Comment on attachment 8974725 [details] Bug 1460624: Switch FIFO buffer to use stl::deque instead of stl::list. https://reviewboard.mozilla.org/r/243094/#review249032
Attachment #8974725 - Flags: review?(matt.woodrow) → review+
Pushed by bschouten@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5f6b2515e170 Switch FIFO buffer to use stl::deque instead of stl::list. r=mattwoodrow
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: