Closed Bug 146066 Opened 22 years ago Closed 20 years ago

[FIXr]should label element retarget events?

Categories

(Core :: Layout: Form Controls, defect, P1)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta1

People

(Reporter: dbaron, Assigned: bzbarsky)

References

Details

(Whiteboard: [whitebox])

Attachments

(1 file)

Fire new events
(deleted), patch
bryner
: review+
jst
: superreview+
Details | Diff | Splinter Review
This is a followup bug to bug 96813. In bug 96813 comment 14 it was suggested that when the label element sends the event routed through its "for" element, it should change the target of the event to the "for" element. See also bug 96813 comment 17.
OS: Linux → All
Hardware: PC → All
-->
Assignee: rods → jkeiser
Priority: -- → P1
Target Milestone: --- → Future
Whiteboard: [whitebox]
We shouldn't be "rerouting" events at all, we should be firing new ones. Bug 271740 is one instance of this.
Depends on: 271740
Attached patch Fire new events (deleted) — — Splinter Review
This makes us fire new events targeted at the right node, and only when we're in the system event group (so it's the "default action" for the label). Doing it only in the system event group fixes bug 276279 (we only SetFocus() once).
Attachment #170412 - Flags: superreview?(jst)
Attachment #170412 - Flags: review?(bryner)
Blocks: 276279
Assignee: john → bzbarsky
Summary: should label element retarget events? → [FIX]should label element retarget events?
Target Milestone: Future → mozilla1.8beta
Comment on attachment 170412 [details] [diff] [review] Fire new events sr=jst
Attachment #170412 - Flags: superreview?(jst) → superreview+
Attachment #170412 - Flags: review?(bryner) → review+
Summary: [FIX]should label element retarget events? → [FIXr]should label element retarget events?
Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 302686 has been marked as a duplicate of this bug. ***
Has this been checked in for Firefox yet? My bug 302686 got marked as a duplicate but I'm seeing bad behavior in Firefox 1.0.6.
This was checked in for all Gecko consumers on 2005-01-20. Firefox 1.0.6 is using a Gecko from 2004-04 with some security fixes.
Blocks: 214368
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: