Looks like specification has been updated since bug 1322858 was implemented. See https://webaudio.github.io/web-audio-api/#AudioWorkletGlobalScope-attributes

Comment on attachment 8975044 [details] Bug 1460896 - Update AudioWorkletGlobalScope definitions; https://reviewboard.mozilla.org/r/243408/#review249508 Looks good to me thanks, but we better check whether a DOM peer wants to review this. ::: dom/worklet/AudioWorkletGlobalScope.cpp:43 (Diff revision 1) > + > + Just a single blank line between functions please.

Andrea, do we need a dom peer to review all webidl changes, or just new interfaces, or just complex changes? From moz.build, I think this file is still BUG_COMPONENT = ("Core", "DOM") Is that best or should we move this to here? BUG_COMPONENT = ("Core", "Web Audio")

Comment on attachment 8975044 [details] Bug 1460896 - Update AudioWorkletGlobalScope definitions; https://reviewboard.mozilla.org/r/243408/#review249536

This change is OK. dom peer reviews are needed for any webIDL change. I'm OK with changing the bug-component in moz.build.

karlt: do you want to update the review to move AudioWorkletGlobalScope to BUG_COMPONENT = ("Core", "Web Audio") or leave it as is, since Andrea said it is OK to have it in "DOM" IIUC? Looking at dom/worklet/moz.build I think PaintWorkletGlobalScope (added as part of bug 1323948) would then also need to be moved to a more specific BUG_COMPONENT, for coherency.

I think we should leave this file with BUG_COMPONENT = ("Core", "DOM"), thanks. BUG_COMPONENT indicates which group owns the files. Changes to these files need dom peer review, but changing the owning group would imply otherwise.

Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/513c6708a333 Update AudioWorkletGlobalScope definitions; r=baku,karlt

Documentation team note: AudioWorklet is currently not expected to ship enabled by default until sometime early in 2019. Given that and some things which are still in flux, we are holding off on documenting it until it’s closer to ready. See bug 1473176, “Document AudioWorklet”.