Closed
Bug 1461048
Opened 7 years ago
Closed 7 years ago
Update FluentDOM to 0.3.0
Categories
(Core :: Internationalization, enhancement, P1)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(2 files)
Once we land https://github.com/projectfluent/fluent.js/pull/195 we'll release new FluentDOM and want to update in-gecko version to unblock bug 1455649.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P1
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Summary: Update Fluent in Gecko to include changes needed for bug 1455649 → Update FluentDOM to 0.3.0
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8975595 [details]
Bug 1461048 - Convert Fluent API calls to FluentDOM 0.3.0.
https://reviewboard.mozilla.org/r/243840/#review249730
::: intl/l10n/DOMLocalization.jsm:648
(Diff revision 1)
> // all translations that is needed for DOM Overlay.
> const overlayTranslations = [];
>
> const getTranslationsForItems = async l10nItems => {
> - const keys = l10nItems.map(l10nItem => [l10nItem.l10nId, l10nItem.l10nArgs]);
> + const keys = l10nItems.map(l10nItem => {
> + return {id: l10nItem.l10nId, args: l10nItem.l10nArgs}
If you want to avoid the braces and return statement you can just wrap the object to return in parentheses ()
Attachment #8975595 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
The first is just a deployment of FluentDOM 0.3.0 - the actual changes were reviewed by :stas in https://github.com/projectfluent/fluent.js/commits/master/fluent-dom
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8975594 [details]
Bug 1461048 - Update FluentDOM to 0.3.0.
https://reviewboard.mozilla.org/r/243838/#review249732
Attachment #8975594 -
Flags: review?(dtownsend) → review+
| Comment hidden (mozreview-request) |
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80651ee9277b
Update FluentDOM to 0.3.0. r=mossop
https://hg.mozilla.org/integration/autoland/rev/1ba2e60eb70b
Convert Fluent API calls to FluentDOM 0.3.0. r=mossop
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/80651ee9277b
https://hg.mozilla.org/mozilla-central/rev/1ba2e60eb70b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•