This padding makes bug 1459400 and bug 1440414 worse.

Comment on attachment 8975245 [details] Bug 1461093 - Remove vertical padding from #titlebar-buttonbox. https://reviewboard.mozilla.org/r/243594/#review249566

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c88cd3fdf873 Remove vertical padding from #titlebar-buttonbox. r=stransky

(In reply to Cosmin Sabou [:CosminS] from comment #4) > https://hg.mozilla.org/mozilla-central/rev/c88cd3fdf873 What about a padding to the right? I cannot believe this patch fixes it.

(In reply to Artem S. Tashkinov from comment #5) > (In reply to Cosmin Sabou [:CosminS] from comment #4) > > https://hg.mozilla.org/mozilla-central/rev/c88cd3fdf873 > > What about a padding to the right? I cannot believe this patch fixes it. No, it wouldn't change that. Please file a new bug on this if there isn't one already tracked under bug 1283299.

Comment on attachment 8975245 [details] Bug 1461093 - Remove vertical padding from #titlebar-buttonbox. Approval Request Comment [Feature/Bug causing the regression]: bug 1434621 [User impact if declined]: bug 1440414 and bug 1459400 [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: This is tricky to verify by QA, as you'd need to try many different Gtk themes. I think we can just rely on the Nightly and Beta community here. [Needs manual test from QE? If yes, steps to reproduce]: / [List of other uplifts needed for the feature/fix]: / [Is the change risky?]: not much [Why is the change risky/not risky?]: I imagine not having the extra vertical padding may look weird with some Gtk themes, but usually this should be an improvement. It certainly is with the Ubuntu 18.04 default theme. [String changes made/needed]: /

Comment on attachment 8975245 [details] Bug 1461093 - Remove vertical padding from #titlebar-buttonbox. Simple Linux-only theme fix. Approved for 61.0b6.