Closed
Bug 1461143
Opened 7 years ago
Closed 7 years ago
Get rid of DBAddonInternal class
Categories
(Toolkit :: Add-ons Manager, enhancement)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Having this as a separate class from AddonInternal only adds confusion and complexity.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8975299 [details]
Bug 1461143: Remove DBAddonInternal class.
https://reviewboard.mozilla.org/r/243626/#review250536
Nice, thanks
::: toolkit/mozapps/extensions/internal/XPIDatabase.jsm:234
(Diff revision 1)
>
> let AddonWrapper;
>
> /**
> - * The AddonInternal is an internal only representation of add-ons. It may
> - * have come from the database (see DBAddonInternal in XPIDatabase.jsm)
> + * The AddonInternal is an internal only representation of add-ons. It
> + * may have come from the database or an install manifest.
nit: "install manifest" isn't a current term, "extension manifest" perhaps?
::: toolkit/mozapps/extensions/internal/XPIDatabase.jsm:272
(Diff revision 1)
> + if (addonData) {
> + if (addonData.descriptor) {
> + if (!addonData.path) {
> + addonData.path = descriptorToPath(addonData.descriptor);
> + }
> + delete addonData.descriptor;
I know you just moved this from elsewhere but I think we could safely delete (ha) this line?
Attachment #8975299 -
Flags: review?(aswan) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8dbaf7e5edd88294f47517457f0ac55c8313655
Bug 1461143: Remove DBAddonInternal class. r=aswan
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.
Thanks!
Flags: needinfo?(kmaglione+bmo)
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•