Closed
Bug 1461632
Opened 6 years ago
Closed 6 years ago
Resolve memset calls on class/struct that are not PODs
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1461556
People
(Reporter: andi, Unassigned)
References
(Blocks 1 open bug)
Details
Using the latest gcc 8 with Werror=class-memaccess a lot of warnings are triggered when clearing inside the ctor the object itself.
The scope of this issue is to fix these issues. Most of them are easily to fix by replacing the memset with the initialization list in the ctor.
Comment 1•6 years ago
|
||
Waldo is already working on it in bug 1461556 (that one also has a fix for the ServoSizes issue from bug 1461600).
Reporter | ||
Comment 2•6 years ago
|
||
I guess we can mark this as a duplicate? Looking here http://paste.debian.net/1024736/ the issues are generated by the Pod memset.
Flags: needinfo?(andrebargull)
Comment 3•6 years ago
|
||
Let's wait for Waldo to chime in, because bug 1461556 comment #1 mentions that there's still some work to do in addition to the patch in bug 1461556.
Flags: needinfo?(andrebargull) → needinfo?(jwalden+bmo)
Comment 4•6 years ago
|
||
I'm going to keep piling patches on bug 1461556, except in those cases where the fix gets notably involved, e.g. bug 1461821.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(jwalden+bmo)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•