Closed Bug 1461844 Opened 6 years ago Closed 2 years ago

searches through the awesomebar should not get the "typed" visit bonus

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed
firefox106 --- fixed

People

(Reporter: mconnor, Assigned: daisuke)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1461844: Add bonus for searched visit.
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details
Post unification, this is a much bigger deal. All searches through the unified awesomebar end up getting marked as TYPED, meaning they get a 20x boost and show up disproportionately vs. expectations. This is because loadURL calls addToUrlbarHistory, which marks everything as typed. But this will also apply to search URLs, which is probably not the ideal. This means that I now almost always have search results in my awesomebar, which seems like a major change post-unification. For now, I'd keep it as a standard visit, but I'd like to be able to weight these independently.
yes, this is pretty much bug 1330343, right?
Now that autofill doesn't depend on typed anymore, we could start fixing the meaning of typed.
Priority: -- → P2
Whiteboard: [fxsearch]
Blocks: 1467631
Component: Search → Address Bar
Points: --- → 3
No longer blocks: qb-results-papercuts
Blocks: 1623848
Depends on: 1635100
No longer blocks: 1623848
Points: 3 → 5
QA Whiteboard: qa-not-actionable

Depends on D153320

Assignee: nobody → daisuke
Status: NEW → ASSIGNED

https://hg.mozilla.org/mozilla-central/rev/1a2602dec7ae

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Comment on attachment 9288236 [details]
Bug 1461844: Add bonus for searched visit.

Beta/Release Uplift Approval Request

  • User impact if declined: When user searches, it is not handled correctly as searched visit, the display priority will not become correct.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The main changes are only 5 lines, and only change the value of the database for searched visits.
  • String changes made/needed: No
  • Is Android affected?: No
Attachment #9288236 - Flags: approval-mozilla-beta?

This bug has been around for 4 years. Is there a Product-related reason driving the uplift request now?

Flags: needinfo?(daisuke)

Yes. This is registered as https://mozilla-hub.atlassian.net/browse/SNT-240 which is included in https://mozilla-hub.atlassian.net/browse/SNT-189.
And, we want to ship all in 105.

Flags: needinfo?(daisuke)

That's good context to have, thanks!

Comment on attachment 9288236 [details]
Bug 1461844: Add bonus for searched visit.

Approved for 105.0b5.

Attachment #9288236 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: