Closed
Bug 1461997
Opened 6 years ago
Closed 6 years ago
Create an ESLint rule to prevent usages of Assert.throws/rejects without an 'expected' argument
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(4 files)
See bug 1452706 for the background, this is for creating the rule and initial whitelist.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8976292 [details]
Bug 1461997 - Enable ESLint rule mozilla/require-expected-throws-or-rejects for browser/components.
https://reviewboard.mozilla.org/r/244470/#review250532
rs=me
Attachment #8976292 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8976456 [details]
Bug 1461997 - Remove unused feeds xpcshell-test that were missed being removed in bug 1420622.
https://reviewboard.mozilla.org/r/244578/#review250644
Attachment #8976456 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 12•6 years ago
|
||
mozreview-review |
Comment on attachment 8976291 [details]
Bug 1461997 - Create a rule to prevent usages of Assert.throws/rejects without an 'expected' argument.
https://reviewboard.mozilla.org/r/244468/#review250784
Attachment #8976291 -
Flags: review?(dtownsend) → review+
Comment 13•6 years ago
|
||
mozreview-review |
Comment on attachment 8976305 [details]
Bug 1461997 - Add an ESLint rule to ensure that Assert.rejects is preceeded by await.
https://reviewboard.mozilla.org/r/244472/#review250786
Attachment #8976305 -
Flags: review?(dtownsend) → review+
Comment 14•6 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74a8b71fcdac
Create a rule to prevent usages of Assert.throws/rejects without an 'expected' argument. r=mossop
https://hg.mozilla.org/integration/autoland/rev/42e510b46e6c
Remove unused feeds xpcshell-test that were missed being removed in bug 1420622. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/2f23cf70c176
Enable ESLint rule mozilla/require-expected-throws-or-rejects for browser/components. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/672e132cb4ad
Add an ESLint rule to ensure that Assert.rejects is preceeded by await. r=mossop
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/74a8b71fcdac
https://hg.mozilla.org/mozilla-central/rev/42e510b46e6c
https://hg.mozilla.org/mozilla-central/rev/2f23cf70c176
https://hg.mozilla.org/mozilla-central/rev/672e132cb4ad
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee | ||
Updated•6 years ago
|
Summary: Create a rule to prevent usages of Assert.throws/rejects without an 'expected' argument → Create an ESLint rule to prevent usages of Assert.throws/rejects without an 'expected' argument
Updated•6 years ago
|
Version: Version 3 → 3 Branch
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•