Julian Descottes [:jdescottes] Reporter
	Description • 6 years ago

The links opening a new tab in the application panel should use devtools/client/shared/link.js

	Nicolas Chevobbe [:nchevobbe]
	Comment 2 • 6 years ago
mozreview-review

Comment on attachment 8980337 [details]
Bug 1462232 - Links don't work if devtools are in a separate window.

https://reviewboard.mozilla.org/r/246490/#review252790

Looks good to me and works well, thanks Belén !
Could we add a test to make sure we don't regress this ?

	Julian Descottes [:jdescottes] Reporter
	Comment 3 • 6 years ago

Note if you want to add a test, the bet will be to test this with about:debugging, because the other links would trigger a network request which is not allowed in tests (or we need a way to update the URLs used to point to local test files instead of MDN links).

	Nicolas Chevobbe [:nchevobbe]
	Comment 4 • 6 years ago

(In reply to Julian Descottes [:jdescottes][:julian] from comment #3)
> Note if you want to add a test, the bet will be to test this with
> about:debugging, because the other links would trigger a network request
> which is not allowed in tests (or we need a way to update the URLs used to
> point to local test files instead of MDN links).

We could only test the about:debugging link maybe ? That way we don't reach the network and we don't have to shim URL opening (that's what we do in the console).

	Pulsebot
	Comment 5 • 6 years ago

Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5807715395d
Links don't work if devtools are in a separate window. r=nchevobbe

	Arthur Iakab [arthur_iakab]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f5807715395d