In most screens of the application panel, we shouldn't allow text selection. The spots where text selection might still be useful are: - scope - source url

Comment on attachment 8980584 [details] Bug 1462237 - Prevent text selection in application panel; https://reviewboard.mozilla.org/r/246734/#review253296 A question about the color choice. Everything else looks good to me! Thanks :) ::: devtools/client/application/src/components/App.css:33 (Diff revision 1) > } > > a.disabled, > a.disabled:hover, > a.disabled:visited { > - opacity: 0.5 !important; > + color: var(--theme-body-color-inactive) !important; Do we have UX input about this? With `--theme-body-color-inactive` disabled links look exactly the same as regular text, and I'm not sure if this is what we'd want

Comment on attachment 8980584 [details] Bug 1462237 - Prevent text selection in application panel; https://reviewboard.mozilla.org/r/246734/#review253296 Thanks for the review! > Do we have UX input about this? With `--theme-body-color-inactive` disabled links look exactly the same as regular text, and I'm not sure if this is what we'd want Oops sorry about this, this was not supposed to be part of this diff. I have a pending question to victoria about this in https://bugzilla.mozilla.org/show_bug.cgi?id=1460209 I'll drop it from the diff.

Comment on attachment 8980584 [details] Bug 1462237 - Prevent text selection in application panel; https://reviewboard.mozilla.org/r/246734/#review253464

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s f54639855b83a32fe43add241a6b7ab6688b6eb3 -d a31957c18991: rebasing 465534:f54639855b83 "Bug 1462237 - Prevent text selection in application panel;r=ladybenko" (tip) merging devtools/client/application/src/components/Worker.css merging devtools/client/application/src/components/Worker.js warning: conflicts while merging devtools/client/application/src/components/Worker.css! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s f54639855b83a32fe43add241a6b7ab6688b6eb3 -d a31957c18991: rebasing 465534:f54639855b83 "Bug 1462237 - Prevent text selection in application panel;r=ladybenko" (tip) merging devtools/client/application/src/components/Worker.css merging devtools/client/application/src/components/Worker.js warning: conflicts while merging devtools/client/application/src/components/Worker.css! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/879d8652dde3 Prevent text selection in application panel;r=ladybenko