Closed
Bug 1462466
Opened 6 years ago
Closed 6 years ago
fix ServiceWorker::PostMessage() when e10s pref is flipped
Categories
(Core :: DOM: Service Workers, defect, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
(Whiteboard: SW-MUST)
Attachments
(4 files, 8 obsolete files)
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Bug 1459209 implements ServiceWorker::PostMessage(), but testing shows that it hits assertions and does not actually work. I'll fix this in a separate bug here since the changes will be a bit intrusive and I don't want to stop the overall reviews going on in the other bug. Since its off behind a pref it can be broken for a bit.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Let's make sure this doesn't break anything with the e10s pref disabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e15eb41dfdffbc5020093cf0e0336dbfb06b16e
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Andrea, this patch adds a new helper ServiceWorkerCloneData class. Its a ref-counted StructuredCloneData implementation. It also proxy releases the SharedJSAllocatedData on the correct source thread. Please see the header comment for more information.
Attachment #8976707 -
Attachment is obsolete: true
Attachment #8977032 -
Flags: review?(amarchesini)
Assignee | ||
Comment 7•6 years ago
|
||
This patch makes us use the new ServiceWorkerCloneData class for the ServiceWorker::PostMessage() path. This nicely avoids having to do the re-packing in ServiceWorkerPrivate. This patch updates both the legacy and new e10s pref'd path added in bug 1459209.
Attachment #8976708 -
Attachment is obsolete: true
Attachment #8977035 -
Flags: review?(amarchesini)
Assignee | ||
Comment 8•6 years ago
|
||
This fixes a typo in StructuredCloneData::CopyFromCloneMessageDataForBackgroundParent(). We need this to work properly for the e10s pref'd path.
Attachment #8976709 -
Attachment is obsolete: true
Assignee | ||
Comment 9•6 years ago
|
||
Comment on attachment 8977036 [details] [diff] [review] P3 Fix StructuredCloneData::CopyFromCloneMessageDataForBackgroundParent() to use CopyMemory instead of BorrowMemory. r=baku See comment 8.
Attachment #8977036 -
Flags: review?(amarchesini)
Assignee | ||
Comment 10•6 years ago
|
||
We don't need the sandbox creation code in ServiceWorkerPrivate any more.
Attachment #8977028 -
Attachment is obsolete: true
Attachment #8977039 -
Flags: review?(amarchesini)
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Attachment #8977032 -
Flags: review?(amarchesini)
Assignee | ||
Updated•6 years ago
|
Attachment #8977035 -
Flags: review?(amarchesini)
Assignee | ||
Updated•6 years ago
|
Attachment #8977036 -
Flags: review?(amarchesini)
Assignee | ||
Updated•6 years ago
|
Attachment #8977039 -
Flags: review?(amarchesini)
Assignee | ||
Comment 11•6 years ago
|
||
I'm going to land this before the IPC code to make things simpler.
Assignee | ||
Comment 12•6 years ago
|
||
Attachment #8977032 -
Attachment is obsolete: true
Assignee | ||
Comment 13•6 years ago
|
||
Attachment #8977035 -
Attachment is obsolete: true
Assignee | ||
Comment 14•6 years ago
|
||
Attachment #8977036 -
Attachment is obsolete: true
Assignee | ||
Comment 15•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d624ce7f79775e54269f40ab6c83713387cef1b1
Attachment #8977039 -
Attachment is obsolete: true
Assignee | ||
Comment 16•6 years ago
|
||
Comment on attachment 8987105 [details] [diff] [review] P1 Add a ServiceWorkerCloneData type with threadsafe ref-counting. r=baku Andrea, this patch adds a new helper ServiceWorkerCloneData class. Its a ref-counted StructuredCloneData implementation. It also proxy releases the SharedJSAllocatedData on the correct source thread. Please see the header comment for more information.
Attachment #8987105 -
Flags: review?(amarchesini)
Assignee | ||
Comment 17•6 years ago
|
||
Comment on attachment 8987106 [details] [diff] [review] P2 Make ServiceWorker::PostMessage() code use the ServiceWorkerCloneData class. r=baku This patch makes us use the new ServiceWorkerCloneData class for the ServiceWorker::PostMessage() path. This nicely avoids having to do the re-packing in ServiceWorkerPrivate.
Attachment #8987106 -
Flags: review?(amarchesini)
Assignee | ||
Comment 18•6 years ago
|
||
Comment on attachment 8987107 [details] [diff] [review] P3 Fix StructuredCloneData::CopyFromCloneMessageDataForBackgroundParent() to use CopyMemory instead of BorrowMemory. r=baku This fixes a typo in StructuredCloneData::CopyFromCloneMessageDataForBackgroundParent().
Attachment #8987107 -
Flags: review?(amarchesini)
Assignee | ||
Comment 19•6 years ago
|
||
Comment on attachment 8987108 [details] [diff] [review] P4 Remove stale sandbox code from ServiceWorkerPrivate. r=baku We don't need the sandbox creation code in ServiceWorkerPrivate any more.
Attachment #8987108 -
Flags: review?(amarchesini)
Updated•6 years ago
|
Whiteboard: SW-MUST
Updated•6 years ago
|
Attachment #8987105 -
Flags: review?(amarchesini) → review+
Updated•6 years ago
|
Attachment #8987106 -
Flags: review?(amarchesini) → review+
Updated•6 years ago
|
Attachment #8987107 -
Flags: review?(amarchesini) → review+
Updated•6 years ago
|
Attachment #8987108 -
Flags: review?(amarchesini) → review+
Comment 20•6 years ago
|
||
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/24cbb43eea80 P1 Add a ServiceWorkerCloneData type with threadsafe ref-counting. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/948ef44381f3 P2 Make ServiceWorker::PostMessage() code use the ServiceWorkerCloneData class. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/e71c74469159 P3 Fix StructuredCloneData::CopyFromCloneMessageDataForBackgroundParent() to use CopyMemory instead of BorrowMemory. r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/101fb5a63031 P4 Remove stale sandbox code from ServiceWorkerPrivate. r=baku
Comment 21•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/24cbb43eea80 https://hg.mozilla.org/mozilla-central/rev/948ef44381f3 https://hg.mozilla.org/mozilla-central/rev/e71c74469159 https://hg.mozilla.org/mozilla-central/rev/101fb5a63031
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•