Closed Bug 1462873 Opened 6 years ago Closed 6 years ago

Bug 1393119 undid bug 1257888

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
3 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr60 fixed, firefox61 fixed, firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1462873 - Link chromium_atomics to webrtc tests.
(deleted), text/x-review-board-request
froydnj
: review+
RyanVM
: approval-mozilla-beta+
RyanVM
: approval-mozilla-esr60+
Details
No description provided.
Attachment #8979014 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment on attachment 8979014 [details] Bug 1462873 - Link chromium_atomics to webrtc tests. https://reviewboard.mozilla.org/r/245286/#review251230
Attachment #8979014 - Flags: review?(nfroyd) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/20cf35432bfa Link chromium_atomics to webrtc tests. r=froydnj
Comment on attachment 8979014 [details] Bug 1462873 - Link chromium_atomics to webrtc tests. [Approval Request Comment] User impact if declined: Build failure on powerpc* (tier-3) platforms Fix Landed on Version: 62 Risk to taking this patch (and alternatives if risky): The patch affects all platforms in that it makes an additional library be linked to the binary, but: - it's a test-only binary - this was happening before a regression in the build system in 60. So overall, risk is very low to inexistent. String or UUID changes made by this patch: N/A
Attachment #8979014 - Flags: approval-mozilla-esr60?
Attachment #8979014 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/20cf35432bfa
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment on attachment 8979014 [details] Bug 1462873 - Link chromium_atomics to webrtc tests. Approved for 61.0b7 and ESR 60.1.
Attachment #8979014 - Flags: approval-mozilla-esr60?
Attachment #8979014 - Flags: approval-mozilla-esr60+
Attachment #8979014 - Flags: approval-mozilla-beta?
Attachment #8979014 - Flags: approval-mozilla-beta+
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: