Closed Bug 1463056 Opened 7 years ago Closed 7 years ago

Not all recipe types are listed to be fetched (@rollout/rollback)

Categories

(Firefox :: Normandy Client, defect)

defect
Not set
trivial

Tracking

()

RESOLVED INVALID
Tracking Status
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- affected
firefox62 --- affected

People

(Reporter: aflorinescu, Unassigned)

References

Details

[Environment:] Windows 8.1 x64 62.0a1 2018-05-21 61.0b6 2018-05-17 [Prerequisites:] 1. Set the app.normandy.dev_mode preference to true to run recipes immediately on startup. 2. Set the app.normandy.logging.level preference to 0 to enable more logging. 3. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90. 4. Set the preference value for app.normandy.api_url set to https://normandy.stage.mozaws.net/api/v1 [Steps:] 1. Open Control Center (https://normandy-admin.stage.mozaws.net/) 2. Set a rollout/rollback recipe that will not apply to any FF client. 3. Set prerequisites and run Firefox. (>=61 version) [Actual Result:] pp.normandy.recipe-runner DEBUG Fetched 33 recipes from the server: {recipe list} - also contains the recipes from step 2, of the type rollout/rollback. app.normandy.recipe-runner DEBUG Fetched 3 actions from the server: opt-out-study, show-heartbeat, preference-experiment app.normandy.recipe-runner DEBUG No recipes to execute [Expected Result:] I would expect that we fetch all recipe types, even if at the current run time, we have none of the rollout/rollback type applying to the FF client.
Actually, I think that not listing the fetch for the rollout/rollback recipes might be just a debug mode issue only, since it doesn't list the type fetch either for when the filters find a suitable rollout/rollback recipe to run. Mike, could there be any other concerns related to this? Based on the above, downgrading the severity of the issue.
Severity: normal → trivial
Summary: Not all recipe types are fetched (@rollout/rollback) → Not all recipe types are listed to be fetched (@rollout/rollback)
"Fetch" refers to a very specific thing in this case: getting things from the server. Since rollout/rollback are implemented in the client they don't need to be fetched from the server. The log line will only show actions fetched from the server. Note that recipes of all types are fetched from the server.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.