Closed Bug 1463223 Opened 6 years ago Closed 6 years ago

Check if the autocomplete popup is initialized before performing any action in the rule view

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: gl, Assigned: gl)

References

Details

Attachments

(1 file)

We lazy loaded the autocomplete popup in the rule view in Bug 1459027, but we call this.popup which initializes the autocomplete popup every time we select an element in the rule view, so we don't really benefit from the lazy loading of the autocomplete popup right now. We should check this._popup to make sure we don't do anything with the autocomplete popup if it isn't even initialized and isn't needed yet.
Comment on attachment 8979349 [details] Bug 1463223 - Check if the autocomplete popup is initialized before performing any action in the rule view. https://reviewboard.mozilla.org/r/245508/#review251696
Attachment #8979349 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ea25cc1e2c52 Check if the autocomplete popup is initialized before performing any action in the rule view. r=pbro
Blocks: 1462648
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
Flags: in-testsuite-
Flags: in-testsuite- → qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: