Since bug 1446164 and bug 1407418 seem like they're still going to take some time, and we'd like to start QA soon, we can adapt l10n.js to do the localization of the shared autofill edit dialogs in the meantime so that the form fields get labels.

Comment on attachment 8979404 [details] Bug 1463292 - Use form autofill's l10n.js in the PaymentRequest dialog. https://reviewboard.mozilla.org/r/245572/#review251886 Field labels! Nice one. ::: browser/components/payments/content/paymentDialogFrameScript.js:100 (Diff revision 1) > > sendToChrome({detail}) { > let {messageType} = detail; > if (messageType == "initializeRequest") { > this.setupContentConsole(); > + this.setupL10n(); Nit: Do we need a comment pointing to bug 1463292 and the plan this is a stop-gap for? ::: browser/extensions/formautofill/content/l10n.js:17 (Diff revision 1) > > +/* global content */ > + > ChromeUtils.import("resource://formautofill/FormAutofillUtils.jsm"); > > +const CONTENT_WIN = typeof(window) != "undefined" ? window : content.window; Same here, presumably CONTENT_WIN is only necessary as long as this workaround for use in webpayment is in place. So maybe a comment here? Or perhaps unnecessary as this whole file goes away in bug 1446164?

Comment on attachment 8979404 [details] Bug 1463292 - Use form autofill's l10n.js in the PaymentRequest dialog. https://reviewboard.mozilla.org/r/245572/#review251886 > Nit: Do we need a comment pointing to bug 1463292 and the plan this is a stop-gap for? I added a comment > Same here, presumably CONTENT_WIN is only necessary as long as this workaround for use in webpayment is in place. So maybe a comment here? Or perhaps unnecessary as this whole file goes away in bug 1446164? There is already a comment at the top of the file explaining that this is temporary until we have Fluent.

Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/5ec5d5b1ab80 Use form autofill's l10n.js in the PaymentRequest dialog. r=sfoster