This is continuing roll-out of require-expected-throws-or-rejects as per bug 1452706.

Comment on attachment 8979671 [details] Bug 1463499 - Enable ESLint rule require-expected-throws-or-rejects for services/. https://reviewboard.mozilla.org/r/245812/#review251980 ::: services/fxaccounts/tests/xpcshell/test_storage_manager.js:194 (Diff revision 2) > sm.plainStorage = new MockedPlainStorage({uid: "uid", email: "someone@somewhere.com"}); > if (sm.secureStorage) { > sm.secureStorage = new MockedSecureStorage(null); > } > - Assert.rejects(sm.updateAccountData({uid: "another"}), "Can't change"); > - Assert.rejects(sm.updateAccountData({email: "someoneelse"}), "Can't change"); > + await sm.initialize(); > + Note: email was allowed to be changed in bug 1383663, but the check here didn't get updated as it wasn't actually catching anything.

Comment on attachment 8979671 [details] Bug 1463499 - Enable ESLint rule require-expected-throws-or-rejects for services/. https://reviewboard.mozilla.org/r/245812/#review251988 Thanks Mark ::: services/fxaccounts/tests/xpcshell/test_storage_manager.js:194 (Diff revision 2) > sm.plainStorage = new MockedPlainStorage({uid: "uid", email: "someone@somewhere.com"}); > if (sm.secureStorage) { > sm.secureStorage = new MockedSecureStorage(null); > } > - Assert.rejects(sm.updateAccountData({uid: "another"}), "Can't change"); > - Assert.rejects(sm.updateAccountData({email: "someoneelse"}), "Can't change"); > + await sm.initialize(); > + doh! Thanks

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6d7e41f8f4b Enable ESLint rule require-expected-throws-or-rejects for services/. r=markh