Closed Bug 1464003 Opened 6 years ago Closed 6 years ago

User appears incorrectly signed out from FxA after changing browser language

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Product:
Firefox for Android Graveyard
Component:
Android Sync
Version:
Firefox 62
Platform:
ARM
Android
Type:
defect

Tracking

(fennec?, firefox60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65+ verified, firefox66+ verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
fennec ? ---
firefox60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 + verified
firefox66 + verified

People

(Reporter: levente.sacal, Assigned: vlad.baicu)

Details

(Whiteboard: [priority:medium])

Attachments

(1 file)

Bug 1464003 - Refresh sync preference after rebuilding the list. r=sdaswani
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details
Device(s): - One Plus 3(Android 6.0.1); - Sony Xperia Z5(Android 7.0); Build(s): - Nightly 62.0a1 (2018-05-23); - Beta 61.0b7 - Release 60.0.1 Steps to reproduce: 1. Log with a FxA account 2. Change the browser language 3. Go back to the custom menu Expected result: - user appears logged in correctly with FxA account after the language change Actual result: - user appears that they are not signed in Notes: - after tapping on Sign in, the user appears as signed in again - also after quitting and reopening the custom menu, the user appears logged in again https://youtu.be/uuRjZPZ-QxI
status-firefox63: --- → affected
status-firefox64: --- → affected
I think This should be triaged as a user might leave his browser for others to use if he things is not connected and this will definitely not be ok from privacy/security reasons. The solution should not imply server side - maybe a refresh only? Either way Ni on Susheel for an opinion.
Component: General → Android Sync
Flags: needinfo?(sdaswani)
If this is just a UI bug the Softvision crew may be able to handle, else we may have to punt it to the Sync team.
Flags: needinfo?(sdaswani)
Whiteboard: [priority:medium]
Assignee: nobody → vlad.baicu
Priority: -- → P1
Can your team try to reproduce this issue in Nightly?
status-firefox60: affected → wontfix
status-firefox61: affected → wontfix
status-firefox62: affected → wontfix
status-firefox63: affected → wontfix
status-firefox65: --- → ?
Flags: needinfo?(ioana.chiorean)
This is still reproducible in the latest Nightly 65.
status-firefox65: ? → affected
Flags: needinfo?(ioana.chiorean)
Tracking to make sure this lands after the holidays/after review.
tracking-firefox65: --- → +
tracking-firefox66: --- → +
Keywords: checkin-needed
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ca6e1f583f4 Refresh sync preference after rebuilding the list. r=Grisha
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0ca6e1f583f4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Please request Beta approval on this when you get a chance.
Flags: qe-verify+
Flags: needinfo?(vlad.baicu)
Comment on attachment 9032960 [details] Bug 1464003 - Refresh sync preference after rebuilding the list. r=sdaswani [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: None User impact if declined: Users will continue to experience an UI bug on some devices. Is this code covered by automated tests?: No Has the fix been verified in Nightly?: Yes Needs manual test from QE?: Yes If yes, steps to reproduce: 1. Log with a FxA account 2. Change the browser language 3. Go back to the custom menu List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): The fix implies merely a reference refresh before recreating the UI. String changes made/needed: None
Flags: needinfo?(vlad.baicu)
Attachment #9032960 - Flags: approval-mozilla-beta?

Comment on attachment 9032960 [details]
Bug 1464003 - Refresh sync preference after rebuilding the list. r=sdaswani

[Triage Comment]
Fixes a confusing UI bug for users on some devices. Approved for 65.0b9.

Attachment #9032960 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed on the following builds: 65.0b9 build 2, and 66.0a1 (2019-01-07).
Device: Samsung Galaxy Tab S3 (Android 8.0).

Status: RESOLVED → VERIFIED
status-firefox65: fixed → verified
status-firefox66: fixed → verified
Flags: qe-verify+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: