Closed
Bug 1464003
Opened 6 years ago
Closed 6 years ago
User appears incorrectly signed out from FxA after changing browser language
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P1)
Tracking
(fennec?, firefox60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65+ verified, firefox66+ verified)
People
(Reporter: levente.sacal, Assigned: vlad.baicu)
Details
(Whiteboard: [priority:medium])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
Device(s):
- One Plus 3(Android 6.0.1);
- Sony Xperia Z5(Android 7.0);
Build(s):
- Nightly 62.0a1 (2018-05-23);
- Beta 61.0b7
- Release 60.0.1
Steps to reproduce:
1. Log with a FxA account
2. Change the browser language
3. Go back to the custom menu
Expected result:
- user appears logged in correctly with FxA account after the language change
Actual result:
- user appears that they are not signed in
Notes:
- after tapping on Sign in, the user appears as signed in again
- also after quitting and reopening the custom menu, the user appears logged in again
https://youtu.be/uuRjZPZ-QxI
Reporter | ||
Updated•6 years ago
|
status-firefox63:
--- → affected
Reporter | ||
Updated•6 years ago
|
status-firefox64:
--- → affected
Comment 1•6 years ago
|
||
I think This should be triaged as a user might leave his browser for others to use if he things is not connected and this will definitely not be ok from privacy/security reasons. The solution should not imply server side - maybe a refresh only?
Either way Ni on Susheel for an opinion.
Component: General → Android Sync
Flags: needinfo?(sdaswani)
If this is just a UI bug the Softvision crew may be able to handle, else we may have to punt it to the Sync team.
Flags: needinfo?(sdaswani)
Whiteboard: [priority:medium]
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → vlad.baicu
Can your team try to reproduce this issue in Nightly?
status-firefox65:
--- → ?
Flags: needinfo?(ioana.chiorean)
Reporter | ||
Comment 4•6 years ago
|
||
This is still reproducible in the latest Nightly 65.
Flags: needinfo?(ioana.chiorean)
status-firefox66:
--- → affected
Assignee | ||
Comment 5•6 years ago
|
||
Tracking to make sure this lands after the holidays/after review.
tracking-firefox65:
--- → +
tracking-firefox66:
--- → +
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ca6e1f583f4
Refresh sync preference after rebuilding the list. r=Grisha
Keywords: checkin-needed
Comment 8•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Comment 9•6 years ago
|
||
Please request Beta approval on this when you get a chance.
Flags: qe-verify+
Flags: needinfo?(vlad.baicu)
Assignee | ||
Comment 10•6 years ago
|
||
Comment on attachment 9032960 [details]
Bug 1464003 - Refresh sync preference after rebuilding the list. r=sdaswani
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: None
User impact if declined: Users will continue to experience an UI bug on some devices.
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: Yes
If yes, steps to reproduce: 1. Log with a FxA account
2. Change the browser language
3. Go back to the custom menu
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): The fix implies merely a reference refresh before recreating the UI.
String changes made/needed: None
Flags: needinfo?(vlad.baicu)
Attachment #9032960 -
Flags: approval-mozilla-beta?
Comment 11•6 years ago
|
||
Comment on attachment 9032960 [details]
Bug 1464003 - Refresh sync preference after rebuilding the list. r=sdaswani
[Triage Comment]
Fixes a confusing UI bug for users on some devices. Approved for 65.0b9.
Attachment #9032960 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 12•6 years ago
|
||
bugherder uplift |
Comment 13•6 years ago
|
||
Verified as fixed on the following builds: 65.0b9 build 2, and 66.0a1 (2019-01-07).
Device: Samsung Galaxy Tab S3 (Android 8.0).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•