Closed
Bug 1464354
Opened 6 years ago
Closed 6 years ago
Disabled links in application panel no longer look disabled
Categories
(DevTools :: Application Panel, defect, P3)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1460209
People
(Reporter: jdescottes, Unassigned)
References
Details
Small UI regression from Bug 1459581.
When disabled, the debug link now has the class worker__debug-link--disabled which doesn't match our selector:
a.disabled,
a.disabled:hover,
a.disabled:visited
Reporter | ||
Comment 1•6 years ago
|
||
:ladybenko: How do you think we should address that according to BEM guidelines? Should we have a "--disabled" classname? Or "link--disabled"?
Flags: needinfo?(balbeza)
Comment 2•6 years ago
|
||
(In reply to Julian Descottes [:jdescottes][:julian] from comment #1)
> :ladybenko: How do you think we should address that according to BEM
> guidelines? Should we have a "--disabled" classname? Or "link--disabled"?
We shouldn't need two classes here to set a link as disabled.
.worker__debug-link--disabled doesn't have any style rules associated, so I'd suggest to use just .disabled here.
The rationale is that we might have other disabled links in then panel, and that's why we have the .disabled class for links. If we had a preprocessor we could just have the .disabled styles as a mixin an import it in every component that needs disabled links –and thus reuse code– but it's not the case here.
Flags: needinfo?(balbeza)
Reporter | ||
Comment 3•6 years ago
|
||
Thanks for the feedback! I'll fix it as part of Bug 1460209 then.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•