Chromium IPC already appears to have atomicops for PowerPC, but the code as written doesn't use them. Furthermore, on ppc64, the fallback mutex code doesn't actually seem to link on this system, which is solved by enabling the atomicops for both (and is better anyway).

Since ARCH_CPU_PPC_FAMILY already exists, we'll just use that (it should have been specified already anyway). Andrew, please advise if you are not an appropriate reviewer, but you seem to have touched this code last.

Fixed context lines, sorry.

Comment on attachment 8981188 [details] [diff] [review] Use proper atomicops for ppc32/ppc64 Review of attachment 8981188 [details] [diff] [review]: ----------------------------------------------------------------- Nathan is more likely than me to be able to give a good review of this.

Comment on attachment 8981188 [details] [diff] [review] Use proper atomicops for ppc32/ppc64 Review of attachment 8981188 [details] [diff] [review]: ----------------------------------------------------------------- If it works for you, it works for me. Thanks.

Comment on attachment 8981188 [details] [diff] [review] Use proper atomicops for ppc32/ppc64 Thank *you*!

Note that this patch is NPOTB, if the lander wants to add that annotation somewhere.

Comment on attachment 8981188 [details] [diff] [review] Use proper atomicops for ppc32/ppc64 Note that we use the checkin-needed keyword to denote that a patch needs to be checked in by somebody else. Sorry for not setting it previously!

Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/26434931b343 Use proper atomicops for ppc32/ppc64. r=froydnj

Could you please backport this fix on firefox 60 esr? thanks