Closed
Bug 1464773
Opened 6 years ago
Closed 6 years ago
Add low-memory event counts to the crash ping
Categories
(Core :: Memory Allocator, enhancement)
Core
Memory Allocator
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
References
(Blocks 1 open bug)
Details
(Whiteboard: [MemShrink:P2])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1450993 +++
Since landing bug 1451005 very few LOW_MEMORY_EVENTS_COMMIT_SPACE samples have been reported, this can mean two things: either we're not detecting the low-commit space condition or we're crashing nonetheless so we never get a main ping with the samples populated. To distinguish between the two we should augment the crash ping to also contain the counts for low-memory events so that we can distinguish between the two scenarios.
Assignee | ||
Comment 1•6 years ago
|
||
Oops, I forgot to change the bug title.
Summary: [meta] Make low-memory detection work properly on Windows → Add low-memory event counts to the crash ping
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Component: General → Memory Allocator
Updated•6 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8981131 [details]
Bug 1464773 - Add low-memory event counts to the crash report; .mielczarek
https://reviewboard.mozilla.org/r/247220/#review254122
::: xpcom/base/AvailableMemoryTracker.cpp:362
(Diff revision 2)
> if ((kLowCommitSpaceThreshold != 0) &&
> (aStat.ullAvailPageFile < kLowCommitSpaceThreshold)) {
> sNumLowCommitSpaceEvents++;
> + CrashReporter::AnnotateCrashReport(
> + NS_LITERAL_CSTRING("LowCommitSpaceEvents"),
> + nsPrintfCString("%" PRIu32, uint32_t(sNumLowCommitSpaceEvents)));
I wonder if at some point in the future we could change `AnnotateCrashReport` to have an overload that took integer types directly and wrote them out using the existing integer serialization code in nsExceptionHandler.cpp? We currently have a few special-case things that get that treatment. It would improve the ergonomics a bit. (Followup fodder, to be clear.)
Attachment #8981131 -
Flags: review?(ted) → review+
Assignee | ||
Comment 5•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8981131 [details]
Bug 1464773 - Add low-memory event counts to the crash report; .mielczarek
https://reviewboard.mozilla.org/r/247220/#review254122
> I wonder if at some point in the future we could change `AnnotateCrashReport` to have an overload that took integer types directly and wrote them out using the existing integer serialization code in nsExceptionHandler.cpp? We currently have a few special-case things that get that treatment. It would improve the ergonomics a bit. (Followup fodder, to be clear.)
I added that in bug 1348273, unfortunately I still cannot land it :( Once that lands I'll convert this to use the overload so that we don't have this much duplicated code.
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb19935b1930
Add low-memory event counts to the crash report; r=ted.mielczarek
Comment 7•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•