Jan de Mooij [:jandem] Assignee
	Description • 6 years ago

Some UbiNode changes:

* Nodes that have a compartment() now also have a realm().

* realm() returns nullptr for cross-compartment wrappers, because they are shared by all realms within the compartment. I added a jsapi-test for this.

* Debugger::ObjectQuery checks the realm() now. We still want to check the compartment too, because we can use that to abandonReferent() - we can't abandon based on the realm check because same-compartment realms can have direct references to each other (the whole point of having same-compartment realms) so we could miss things if we did that.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]
	Comment 1 • 6 years ago

Comment on attachment 8981572 [details] [diff] [review]
Patch

Review of attachment 8981572 [details] [diff] [review]:
-----------------------------------------------------------------

Wonderful! Thanks jandem!

	Pulsebot
	Comment 2 • 6 years ago

Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee68c73f661b
Some UbiNode changes for same-compartment realms. r=fitzgen

	Andreea Pavel [:apavel]
	Comment 3 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ee68c73f661b