Closed Bug 1465413 Opened 7 years ago Closed 6 years ago

Test Pilot experiments cannot be enabled from the website if they are disabled in "about:addons" page

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Platform:
x86_64
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified

People

(Reporter: cmuntean, Assigned: kmag)

References

Details

(Keywords: regression)

Attachments

(2 files)

Disabled experiments.mp4
(deleted), video/mp4
Details
Bug 1465413: Fix mozAddonManager enable/disable API.
(deleted), text/x-review-board-request
aswan
: review+
Details
Attached video Disabled experiments.mp4 (deleted) —
[Affected versions]: - Nightly 62.0.1 (Build ID: 20180529220039) [Affected Platforms]: - All Windows - All Mac OS - All Linux [Steps to reproduce]: 1. Open latest Nightly build and navigate to "https://testpilot.stage.mozaws.net/notes" page. 2. Click the "Install Tetst Pilot & Enable Notes" button. 3. Navigate to "about:addons" page and disable Notes experiment. 4. Navigate to "https://testpilot.stage.mozaws.net/notes" page. 5. Click the "Enable Notes" button. 6. Observe the behavior. [Expected result]: - The experiment is successfully enabled. [Actual result]: - The "Uh oh. Notes could not be enabled. Try again later". [Regression]: Last good revision: 95175977ef46cb68ea989411fea514a621af1df9 First bad revision: 0461688b6a091d3088f32206a449d9add7142948 Pushlog: https://goo.gl/hr33Yc [Notes]: - Here is a screenshot with browser console errors: https://goo.gl/aMouw5 - Attached a screen recording of the issue.
Kris, can you please take a look at this issue and also over the provided pushlog? I am not sure but probably bug 1461146 introduced this.
Flags: needinfo?(kmaglione+bmo)
David, can you give this a priority? THanks.
Flags: needinfo?(ddurst)
Comment on attachment 8983924 [details] Bug 1465413: Fix mozAddonManager enable/disable API. https://reviewboard.mozilla.org/r/249774/#review256002
Attachment #8983924 - Flags: review?(aswan) → review+
Assignee: nobody → kmaglione+bmo
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(ddurst)
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/a46d2f417a81
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
I have verified this issue on latest Nightly (62.0a1 Build ID: 20180610220159) and the issue is no longer reproducible. Tested on Windows 7 x64, Mac 10.13 and Arch linuc 4.12.
Status: RESOLVED → VERIFIED
status-firefox62: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: