Andrew Reporter
	Description • 6 years ago

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180516032328

Steps to reproduce:

Steps to reproduce:

- Start Firefox 58+ with clean profile.
- Install "Tab Unloader (WebExtension)" https://addons.mozilla.org/firefox/addon/tab-unloader-we/ 
    a) Open search site (google e.g.),
    b) Type some search query, like "test"
    c) Open ~10 links from search results. 
    d) Don't visit them (this can be important) wait for full load AND then - for automatic discarding.
- Visit unloaded tabs - some of them were "spoiled".



Actual results:

When you use an addons that unload tabs through a new tabs.discard () API,
sometimes some tabs fail to restore - 
they are empty (completely blank white page), with empty address bar, non-clickable "Back" button,
only with a title on the tab.

Addons where this problem was observed:
https://addons.mozilla.org/firefox/addon/auto-tab-discard/ 
- temporarily fixed by the author (see references)

https://addons.mozilla.org/firefox/addon/tab-unload-for-tree-style-tab/ 
- temporarily fixed by the author (see references)

https://addons.mozilla.org/firefox/addon/tab-unloader-we/ 
- the problem is still observed

Some references (issues):
https://github.com/rNeomy/auto-tab-discard/issues/24
https://github.com/Lej77/tab-unloader-for-tree-style-tab/issues/4


Expected results:

The discarded tabs are restored correctly after the resumption (selecting).

	Andrew Reporter
	Comment 1 • 6 years ago

UPD:

https://github.com/Lej77/tab-unloader-for-tree-style-tab/issues/4#issuecomment-393921617

Lej77:

> "Broken" tabs

- If a tab is discarded with the WebExtension browser.tabs.discard function then the tab can be broken so that it won't restore correctly. I haven't observed any "broken" tabs from tabs that are discarded when a window is closed and then re-opened.

- I can't find any difference between "broken" tabs and "working" tabs from the information provided by the WebExtensions API, they look the same and seems to have the same onUpdate events before they are discarded.

> Behavior of "broken" tabs

- If a "broken" tab is activated or reloaded then it will change to the about:blank URL and its original URL is lost. (It has the correct URL while it is unloaded.) (This is the issue that my workaround fixes.)

- If a "broken" tab is closed then it won't show up in the recently closed tab list and can't be re-opened.

- If a window is closed and it contains "broken" tabs then the window will still be added to the recently closed windows. The entry will say that it contains the correct number of tabs but when the window is restored all the "broken" tabs will be created with the about:blank URL and their original URL is lost.

- If you close Firefox and then use "restore last session" when you start it again (either automatically or manually from the hamburger menu) then none of the "broken" tabs will be opened at all.

	Andrew Reporter
	Comment 2 • 6 years ago

UPD.

Found this bug on UnloadTabs:

https://addons.mozilla.org/firefox/addon/unload-tabs/

Only 2 of 10 tabs restored properly (see "Steps to reproduce").

	Andrew Reporter
	Comment 3 • 6 years ago

Interesting information

rNeomy ("Auto Tab Discard" author) released a temporarily fix for addon:
https://github.com/rNeomy/auto-tab-discard/commit/7836ef1
This fix works correctly almost always (perhaps in 99 out of 100 cases).

Lej77 ("tab-unloader-for-tree-style-tab" author) released a temporarily fix for addon,
the code for the fix is located in the common/common.js file at line 3778 in the TabRestoreFixer class:
https://github.com/Lej77/tab-unloader-for-tree-style-tab/blob/master/common/common.js#L3778
This fix works too.

Maybe this will help somehow.

	Shane Caraveo (:mixedpuppy)
	Comment 4 • 6 years ago

This sounds very similar to bug 1422588, which landed after comment 3.  Can you retest this?

	Shane Caraveo (:mixedpuppy)
	Comment 5 • 6 years ago

no response on ni? so duping to what I think was the actual bug.