Closed
Bug 1465700
Opened 6 years ago
Closed 6 years ago
Remove JS_DeprecatedGetCompartmentPrincipals
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla67
People
(Reporter: jandem, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Bug 1464374 replaced most JS_GetCompartmentPrincipals calls with JS::GetRealmPrincipals, but there are a few more complicated ones left. This is a blocker for the Gecko changes. On the JS engine side we can work around it by release-asserting single-realm and then just returning that realm's principals.
Updated•6 years ago
|
status-firefox63:
--- → fix-optional
Priority: -- → P2
Reporter | ||
Comment 1•6 years ago
|
||
On top of the patches in the dependent bugs, the main user now is xpc::GetCompartmentPrincipal, and at this point that's called by: * AccessCheck::subsumes * AccessCheck::subsumesConsideringDomain * AccessCheck::subsumesConsideringDomainIgnoringFPD None of these have a *ton* of callers so hopefully this won't be too hard to fix.. (There are also two JS_GetCompartmentPrincipals calls in WindowDestroyedEvent.cpp, for the wrapper nuking, but these are probably easier to deal with.)
Reporter | ||
Comment 2•6 years ago
|
||
Once the dependent bugs are all fixed the remaining uses will be: 1) js::CompartmentsWithPrincipals::match, this is used in the document.domain code with RecomputeWrappers and that will go away at some point. 2) xpc::GetCompartmentPrincipal. The remaining callers of that are AccessCheck::subsumesConsideringDomain{IgnoringFPD} and these are now only used in the wrapping code. These calls will also go away with the other Gecko changes.
Updated•6 years ago
|
status-firefox64:
--- → affected
status-firefox65:
--- → affected
Reporter | ||
Updated•6 years ago
|
Summary: Remove JS_GetCompartmentPrincipals → Remove JS_DeprecatedGetCompartmentPrincipals
Assignee | ||
Comment 3•6 years ago
|
||
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/526f7b418884 Remove the now-unused JS_DeprecatedGetCompartmentPrincipals API. r=jandem
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Updated•6 years ago
|
status-firefox66:
--- → ?
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•