Closed
Bug 1465728
Opened 6 years ago
Closed 6 years ago
Remove the compartment name callback
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(3 files)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
This requires some XPConnect surgery: the location info in CompartmentPrivate needs to live in RealmPrivate, and after that we can remove the compartment name callback and use the realm name callback everywhere.
Assignee | ||
Comment 1•6 years ago
|
||
The xpcprivate.h changes are just code motion, except I changed the order of the GetLocationURI methods to get a much more readable diff.
I'll rename Cu.getCompartmentLocation in a different patch.
Attachment #8982150 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•6 years ago
|
||
I renamed CompartmentNameCallback to GetRealmNameCallback ("Get" prefix), to avoid conflicts with the JS::RealmNameCallback type.
Attachment #8982151 -
Flags: review?(luke)
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8982153 -
Flags: review?(bzbarsky)
Updated•6 years ago
|
Attachment #8982151 -
Flags: review?(luke) → review+
Comment 4•6 years ago
|
||
Comment on attachment 8982150 [details] [diff] [review]
Part 1 - Move location and locationURI fields from CompartmentPrivate to RealmPrivate
r=me
Attachment #8982150 -
Flags: review?(bzbarsky) → review+
Comment 5•6 years ago
|
||
Comment on attachment 8982153 [details] [diff] [review]
Part 3 - Rename Cu.getCompartmentLocation to Cu.getRealmLocation
r=me
Attachment #8982153 -
Flags: review?(bzbarsky) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d422fb97474
part 1 - Move location and locationURI fields from CompartmentPrivate to RealmPrivate. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/84aa50d4663a
part 2 - Remove the compartment name callback. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff7f3a604779
part 3 - Rename Cu.getCompartmentLocation to Cu.getRealmLocation. r=bz
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2d422fb97474
https://hg.mozilla.org/mozilla-central/rev/84aa50d4663a
https://hg.mozilla.org/mozilla-central/rev/ff7f3a604779
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•